[GitHub] [kafka] dajac commented on pull request #10141: KAFKA-12329; kafka-reassign-partitions command should give a better error message when a topic does not exist

[GitBox <gi...@apache.org>]

dajac commented on pull request #10141:
URL: https://github.com/apache/kafka/pull/10141#issuecomment-787783411


   > @dajac Nice improvement. Some minor comments are left. Please take a look.
   > 
   > 1. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java#L1893 also check the existence of topic. Will it become a redundant check after we merge this PR?
   > 2. Should we apply this readable error message to other APIs? `deleteTopics`, for example.
   
   @chia7712 Thanks for your comment. To answer your questions:
   1. No, it is not. That one throws an exception if the topic was not returned at all by the broker.
   2. That's a good question... I do agree that it is a bit weird to do this only in one case. Thinking about this, I think that it might be better to keep the error generic in the admin client and to handle it on the calling side instead. I will try this so we can compare.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org