You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/02/21 20:25:10 UTC
[GitHub] [couchdb-helm] willholley opened a new pull request #24: Use Chart
Testing v3
willholley opened a new pull request #24: Use Chart Testing v3
URL: https://github.com/apache/couchdb-helm/pull/24
<!--
Thank you for contributing to couchdb-helm. Before you submit this PR we'd like to
make sure you are aware of the chart technical requirements and best practices:
* https://github.com/helm/charts/blob/master/CONTRIBUTING.md#technical-requirements
* https://github.com/helm/helm/tree/master/docs/chart_best_practices
For a quick overview across what we will look at reviewing your PR, please read
our review guidelines:
* https://github.com/helm/charts/blob/master/REVIEW_GUIDELINES.md
Following our best practices right from the start will accelerate the review process and
help get your PR merged quicker.
When updates to your PR are requested, please add new commits and do not squash the
history. This will make it easier to identify new changes. The PR will be squashed
anyways when it is merged. Thanks.
Please make sure you test your changes before you push them.
-->
#### What this PR does / why we need it:
Upgrades chart testing to v3 beta 1. This is just to stay current with Kind versions.
#### Which issue this PR fixes
n/a
#### Special notes for your reviewer:
#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.
- [ ] Chart Version bumped
- [ ] e2e tests pass
- [ ] Variables are documented in the README.md
- [ ] Chart tgz added to /docs and index updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] arnediekmann commented on issue #24: Use Chart
Testing v3
Posted by GitBox <gi...@apache.org>.
arnediekmann commented on issue #24: Use Chart Testing v3
URL: https://github.com/apache/couchdb-helm/pull/24#issuecomment-590315247
@willholley this PR alone does not work with kind `0.7.0`. I also had to change `kind get kubeconfig-path ...` to `kind get kubeconfig`:
```patch
From 3b9166768457c55f2a8f1334aa0c905a8cf851ce Mon Sep 17 00:00:00 2001
From: Arne Diekmann <ar...@neoskop.de>
Date: Mon, 24 Feb 2020 14:15:41 +0100
Subject: [PATCH] Migrate from kubeconfig-path to kubeconfig
---
test/e2e-kind.sh | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/test/e2e-kind.sh b/test/e2e-kind.sh
index 36b96ac..efcebd1 100755
--- a/test/e2e-kind.sh
+++ b/test/e2e-kind.sh
@@ -45,9 +45,10 @@ create_kind_cluster() {
docker_exec mkdir -p /root/.kube
echo 'Copying kubeconfig to container...'
- local kubeconfig
- kubeconfig="$(kind get kubeconfig-path --name "$CLUSTER_NAME")"
+ local kubeconfig=$(mktemp)
+ kind get kubeconfig --name "$CLUSTER_NAME" >"$kubeconfig"
docker cp "$kubeconfig" ct:/root/.kube/config
+ rm "$kubeconfig"
docker_exec kubectl cluster-info
echo
--
2.20.1
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] willholley commented on issue #24: Use Chart Testing
v3
Posted by GitBox <gi...@apache.org>.
willholley commented on issue #24: Use Chart Testing v3
URL: https://github.com/apache/couchdb-helm/pull/24#issuecomment-590360381
thanks @arnediekmann - updated with your patch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb-helm] arnediekmann commented on issue #24: Use Chart
Testing v3
Posted by GitBox <gi...@apache.org>.
arnediekmann commented on issue #24: Use Chart Testing v3
URL: https://github.com/apache/couchdb-helm/pull/24#issuecomment-590364396
I pulled your changes real quick and ran `make test` and can verify that the branch is working with kind `0.7.0` :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services