[jira] Commented: (THRIFT-377) TFileTransport port in Java

["Bryan Duxbury (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12901069#action_12901069 ] 

Bryan Duxbury commented on THRIFT-377:
--------------------------------------

I'm sorry to have ignored this ticket for so long. The patch looks generally good, but I don't know enough about it to say for sure. 

I am inclined to commit this patch as-is, but I would really, really like if there was a unit test attached. Is there any way that I could beg for just that teensy addition before I commit?

> TFileTransport port in Java
> ---------------------------
>
>                 Key: THRIFT-377
>                 URL: https://issues.apache.org/jira/browse/THRIFT-377
>             Project: Thrift
>          Issue Type: New Feature
>          Components: Java - Library
>            Reporter: Joydeep Sen Sarma
>         Attachments: 377.2.patch, thrift-377.patch.3
>
>
> there are environments in which data is being logged in TFileTransport (presumably C++ land) and data is desired to be consumed/imported into Hadoop.
> For this a Java version of TFileTransport is required. I am planning to post one that only reads the data - this code is already in use and tested and fulfils the current requirements.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.