[jira] [Commented] (HIVE-22484) Remove Calls to printStackTrace

["Peter Vary (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-22484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972800#comment-16972800 ] 

Peter Vary commented on HIVE-22484:
-----------------------------------

[~belugabehr]: Could we have a pull request, or review board? I prefer to print the stacktrace to logs for the cases where only the error message is returned. Otherwise the source of the problem is lost. I think we should print out them at least to the logs.

Thanks,
Peter

> Remove Calls to printStackTrace
> -------------------------------
>
>                 Key: HIVE-22484
>                 URL: https://issues.apache.org/jira/browse/HIVE-22484
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 3.2.0
>            Reporter: David Mollitor
>            Assignee: David Mollitor
>            Priority: Major
>         Attachments: HIVE-22484.1.patch
>
>
> In many cases, the call to {{printStackTrace}} bypasses the logging framework, in other cases, the error stack trace is printed and the exception is re-thrown (log-and-throw is a bad pattern), and then there are some other edge cases.
> Remove this call and replace with calls to the logging framework or remove altogether if exception is wrapped and re-thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)