You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2018/09/04 23:40:46 UTC

[GitHub] ctubbsii commented on a change in pull request #191: Several updates to Uno

ctubbsii commented on a change in pull request #191: Several updates to Uno
URL: https://github.com/apache/fluo-uno/pull/191#discussion_r215098007
 
 

 ##########
 File path: bin/impl/fetch.sh
 ##########
 @@ -16,22 +16,46 @@
 
 source "$UNO_HOME"/bin/impl/util.sh
 
-function download_verify() {
+function download_other() {
+  url_prefix=$1
+  tarball=$2
+  expected_hash=$3
 
 Review comment:
   These variables should be defined as local variables, as in:
   ```bash
   local url_prefix; url_prefix=$1
   ```
   
   Always a good idea to run shellcheck also.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services