You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/01/07 08:22:24 UTC
[GitHub] [incubator-dolphinscheduler] gabrywu opened a new pull request
#1747: why not invoke checkWorkerGroup in advance
gabrywu opened a new pull request #1747: why not invoke checkWorkerGroup in advance
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1747
## Background
In FetchTaskThread.run method, checkWorkerGroup invoke after "queryUserQueueByProcessInstanceId", why not just after getTaskInstanceDetailByTaskId
if checkWorkerGroup check failed , the rest of the logic can be ignored
## Solution
checkWorkerGroup invoked after getTaskInstanceDetailByTaskId
if (verifyTaskInstanceIsNull(taskInstance)) {
logger.warn("remove task queue : {} due to taskInstance is null", taskQueueStr);
removeNodeFromTaskQueue(taskQueueStr);
continue;
}
if(!checkWorkerGroup(taskInstance, OSUtils.getHost())){
continue;
}
> https://github.com/apache/incubator-dolphinscheduler/issues/1743
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1747:
why not invoke checkWorkerGroup in advance
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1747: why not invoke checkWorkerGroup in advance
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1747#issuecomment-571488319
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=h1) Report
> Merging [#1747](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/7762a622701929a8c9bd48ded0332e2eaa3388ee?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1747 +/- ##
==========================================
- Coverage 20.27% 20.27% -0.01%
==========================================
Files 287 287
Lines 14039 14039
Branches 2369 2369
==========================================
- Hits 2847 2846 -1
- Misses 10867 10868 +1
Partials 325 325
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...cheduler/server/worker/runner/FetchTaskThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvRmV0Y2hUYXNrVGhyZWFkLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...scheduler/alert/template/AlertTemplateFactory.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC90ZW1wbGF0ZS9BbGVydFRlbXBsYXRlRmFjdG9yeS5qYXZh) | `42.85% <0%> (-14.29%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=footer). Last update [7762a62...3278f83](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1747?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-dolphinscheduler] Technoboy- merged pull request #1747:
why not invoke checkWorkerGroup in advance
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1747: why not invoke checkWorkerGroup in advance
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1747
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services