You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/01/21 16:33:43 UTC
[GitHub] [cordova-plugin-screen-orientation] iktumi opened a new pull request #77: Update ScreenOrientation js
iktumi opened a new pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77
Fixing a problem that was making the screen not to be locked as described on https://www.outsystems.com/forums/discussion/67761/resolveorientation-bug/
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
### Description
<!-- Describe your changes in detail -->
### Testing
<!-- Please describe in detail how you tested your changes. -->
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] timbru31 commented on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764910283
No you don’t need to anything - I’ll wait for a pair of second eyes to review the changes and then will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] iktumi commented on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
iktumi commented on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764890037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] iktumi commented on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
iktumi commented on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764890037
Cool, what is the process now ? I am using github pull request for the first time
Will these changes be merged into master? Do I need to do anything mroe?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] iktumi edited a comment on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
iktumi edited a comment on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764955288
Ah I found out this while trying to use the plugin, and haven't looked before in the opened issues.
It seems to me that the issue is this one : https://github.com/apache/cordova-plugin-screen-orientation/issues/70 how can I link it ?
EDIT : ok now I am sure this issue is related to this fix , as in the description of the issue there is also a fix for the same line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] iktumi commented on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
iktumi commented on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764955288
Ah I found out this while trying to use the plugin, and haven't looked before in the opened issues.
It seems to me that the issue is this one : https://github.com/apache/cordova-plugin-screen-orientation/issues/70 how can I link it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] timbru31 commented on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764910283
No you don’t need to anything - I’ll wait for a pair of second eyes to review the changes and then will merge it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] iktumi edited a comment on pull request #77: Update ScreenOrientation js
Posted by GitBox <gi...@apache.org>.
iktumi edited a comment on pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77#issuecomment-764955288
Ah I found out this while trying to use the plugin, and haven't looked before in the opened issues.
It seems to me that the issue is this one : https://github.com/apache/cordova-plugin-screen-orientation/issues/70 how can I link it ?
EDIT : ok now I am sure this issue is related to this fix , as in the description of the issue there is also a fix for the same line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-screen-orientation] timbru31 merged pull request #77: fix: resolveOrientation function not working correctly
Posted by GitBox <gi...@apache.org>.
timbru31 merged pull request #77:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org