You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by Hyunsik Choi <hy...@apache.org> on 2014/04/10 10:23:15 UTC
Review Request 20199: TAJO-745: APIs in TajoClient and JDBC should be case
sensitive.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20199/
-----------------------------------------------------------
Review request for Tajo.
Bugs: TAJO-745
https://issues.apache.org/jira/browse/TAJO-745
Repository: tajo
Description
-------
Identifiers that APIs in TajoClient and Tajo JDBC driver take are normalized in client API side. So, identifiers composed of upper and lower mixed characters should be used with double quote ("). This convention is different from existing JDBC driver's convention. It makes ugly code when users use TajoClient.
This patch changes their APIs to be case sensitive. In addition, this patch adds some missing JDBC APIs and fixes wrong behaviors of getTables() and getColumns() in JDBC APIs.
Diffs
-----
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java c695fc8
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 5bcb290
tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java 2e29536
tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java e6b0bcd
tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 32d09df
tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java ad607a1
tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/LikePredicateEval.java e1c693e
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java ed943f2
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java ad93738
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java a6bb467
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java 78714c5
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java 6d72ca7
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java PRE-CREATION
tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java 9d0352c
tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql eeab457
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result PRE-CREATION
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables1.result 2d89f42
tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables2.result 042cb52
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoConnection.java 5d967e8
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java ac122c8
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java c537eb5
tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java b7604a8
Diff: https://reviews.apache.org/r/20199/diff/
Testing
-------
mvn clean install [passed]
mvn clean test -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore [passed]
Thanks,
Hyunsik Choi
Re: Review Request 20199: TAJO-745: APIs in TajoClient and JDBC should be
case sensitive.
Posted by Hyunsik Choi <hy...@apache.org>.
> On April 10, 2014, 5:48 p.m., Jung JaeHwa wrote:
> > +1.
> >
> > Push it. :)
Thank you for quick review.
- Hyunsik
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20199/#review39995
-----------------------------------------------------------
On April 10, 2014, 5:23 p.m., Hyunsik Choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20199/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 5:23 p.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-745
> https://issues.apache.org/jira/browse/TAJO-745
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Identifiers that APIs in TajoClient and Tajo JDBC driver take are normalized in client API side. So, identifiers composed of upper and lower mixed characters should be used with double quote ("). This convention is different from existing JDBC driver's convention. It makes ugly code when users use TajoClient.
>
> This patch changes their APIs to be case sensitive. In addition, this patch adds some missing JDBC APIs and fixes wrong behaviors of getTables() and getColumns() in JDBC APIs.
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java c695fc8
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 5bcb290
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java 2e29536
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java e6b0bcd
> tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 32d09df
> tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java ad607a1
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/LikePredicateEval.java e1c693e
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java ed943f2
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java ad93738
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java a6bb467
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java 78714c5
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java 6d72ca7
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java 9d0352c
> tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql eeab457
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables1.result 2d89f42
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables2.result 042cb52
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoConnection.java 5d967e8
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java ac122c8
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java c537eb5
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java b7604a8
>
> Diff: https://reviews.apache.org/r/20199/diff/
>
>
> Testing
> -------
>
> mvn clean install [passed]
>
> mvn clean test -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore [passed]
>
>
> Thanks,
>
> Hyunsik Choi
>
>
Re: Review Request 20199: TAJO-745: APIs in TajoClient and JDBC should be
case sensitive.
Posted by Jung JaeHwa <jh...@gruter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20199/#review39995
-----------------------------------------------------------
Ship it!
+1.
Push it. :)
- Jung JaeHwa
On April 10, 2014, 8:23 a.m., Hyunsik Choi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20199/
> -----------------------------------------------------------
>
> (Updated April 10, 2014, 8:23 a.m.)
>
>
> Review request for Tajo.
>
>
> Bugs: TAJO-745
> https://issues.apache.org/jira/browse/TAJO-745
>
>
> Repository: tajo
>
>
> Description
> -------
>
> Identifiers that APIs in TajoClient and Tajo JDBC driver take are normalized in client API side. So, identifiers composed of upper and lower mixed characters should be used with double quote ("). This convention is different from existing JDBC driver's convention. It makes ugly code when users use TajoClient.
>
> This patch changes their APIs to be case sensitive. In addition, this patch adds some missing JDBC APIs and fixes wrong behaviors of getTables() and getColumns() in JDBC APIs.
>
>
> Diffs
> -----
>
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java c695fc8
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java 5bcb290
> tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/Column.java 2e29536
> tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java e6b0bcd
> tajo-client/src/main/java/org/apache/tajo/client/TajoClient.java 32d09df
> tajo-common/src/main/java/org/apache/tajo/util/StringUtils.java ad607a1
> tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/eval/LikePredicateEval.java e1c693e
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/QueryTestCaseBase.java ed943f2
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java ad93738
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCreateTable.java a6bb467
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinBroadcast.java 78714c5
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java 6d72ca7
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoDatabaseMetaData.java PRE-CREATION
> tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/jdbc/TestTajoJdbc.java 9d0352c
> tajo-core/tajo-core-backend/src/test/resources/queries/TestAlterTable/alter_table_rename_table_ddl.sql eeab457
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables1.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoDatabaseMetaData/getTables2.result PRE-CREATION
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables1.result 2d89f42
> tajo-core/tajo-core-backend/src/test/resources/results/TestTajoJdbc/getTables2.result 042cb52
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoConnection.java 5d967e8
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDatabaseMetaData.java ac122c8
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoDriver.java c537eb5
> tajo-jdbc/src/main/java/org/apache/tajo/jdbc/TajoStatement.java b7604a8
>
> Diff: https://reviews.apache.org/r/20199/diff/
>
>
> Testing
> -------
>
> mvn clean install [passed]
>
> mvn clean test -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore [passed]
>
>
> Thanks,
>
> Hyunsik Choi
>
>