You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/22 05:28:45 UTC

[GitHub] [incubator-nuttx-testing] btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions

btashton commented on a change in pull request #17: Add Dockerfile for CI system and hook into GitHub Actions
URL: https://github.com/apache/incubator-nuttx-testing/pull/17#discussion_r396056207
 
 

 ##########
 File path: docker/linux/Dockerfile
 ##########
 @@ -0,0 +1,151 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
 
 Review comment:
   Changing the name from `Dockerfile` is actually kind of annoying for some clients like `buildctl` which will actually build this faster, also it breaks syntax highlighting since there is no known extension, just a filename standard.
   
   It also gives us a folder for OS specific assets that might want to be included which might be nice.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services