You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/19 16:29:59 UTC

[GitHub] [airflow] potiuk opened a new pull request #11662: Bats tests should be much faster now for pre-commits.

potiuk opened a new pull request #11662:
URL: https://github.com/apache/airflow/pull/11662


   For pre-commit run of the tests only the corresponding tests
   for changed .sh files and changed .bats files should be run
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on pull request #11662: Bats tests should be much faster now for pre-commits.

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #11662:
URL: https://github.com/apache/airflow/pull/11662#issuecomment-712314953


   Also random failure. Otherwise it is good!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11662: Bats tests should be much faster now for pre-commits.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11662:
URL: https://github.com/apache/airflow/pull/11662#issuecomment-712285433


   cc: @OmairK  -> this is what we were talking about once. With this script bats tests will actually use the power of pre-commits and will only locally run those bats tests which were modified or only those tests that correspond to the modified files. This way we can add more bats tests with almost no impact on speed of (pre)commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11662: Bats tests should be much faster now for pre-commits.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11662:
URL: https://github.com/apache/airflow/pull/11662#issuecomment-712602796


   Small improvement - but useful for pre-commit users who modify scripts (also allows adding more tests)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11662: Bats tests should be much faster now for pre-commits.

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11662:
URL: https://github.com/apache/airflow/pull/11662#issuecomment-712314953


   Also ransom failure. Otherwise it is good!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #11662: Bats tests should be much faster now for pre-commits.

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11662:
URL: https://github.com/apache/airflow/pull/11662


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org