You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "zhaojinchao95 (via GitHub)" <gi...@apache.org> on 2023/02/21 07:46:16 UTC

[GitHub] [shardingsphere] zhaojinchao95 opened a new pull request, #24275: Refactor drop database stop heartbeat job and remove storage node data sources.

zhaojinchao95 opened a new pull request, #24275:
URL: https://github.com/apache/shardingsphere/pull/24275

   Fixes #24274 .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tuichenchuxin merged pull request #24275: Refactor drop database stop heartbeat job and remove storage node data sources.

Posted by "tuichenchuxin (via GitHub)" <gi...@apache.org>.
tuichenchuxin merged PR #24275:
URL: https://github.com/apache/shardingsphere/pull/24275


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #24275: Refactor drop database stop heartbeat job and remove storage node data sources.

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24275:
URL: https://github.com/apache/shardingsphere/pull/24275#issuecomment-1438154089

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#24275](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecd99f0) into [master](https://codecov.io/gh/apache/shardingsphere/commit/411d65185bfec801de05c78698ea1e08461fa4ab?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (411d651) will **decrease** coverage by `0.06%`.
   > The diff coverage is `30.57%`.
   
   > :exclamation: Current head ecd99f0 differs from pull request most recent head 14c48be. Consider uploading reports for the commit 14c48be to get more accurate results
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #24275      +/-   ##
   ============================================
   - Coverage     49.96%   49.90%   -0.06%     
   + Complexity     1575     1573       -2     
   ============================================
     Files          3252     3253       +1     
     Lines         53385    53429      +44     
     Branches       9836     9850      +14     
   ============================================
   - Hits          26672    26662      -10     
   - Misses        24349    24399      +50     
   - Partials       2364     2368       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...umn/value/string/MySQLJsonBinlogProtocolValue.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGItcHJvdG9jb2wvbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RiL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS9zdHJpbmcvTXlTUUxKc29uQmlubG9nUHJvdG9jb2xWYWx1ZS5qYXZh) | `90.90% <ø> (ø)` | |
   | [...ate/DropDatabaseDiscoveryRuleStatementUpdater.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmVhdHVyZXMvZGItZGlzY292ZXJ5L2Rpc3RzcWwvaGFuZGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGJkaXNjb3ZlcnkvZGlzdHNxbC9oYW5kbGVyL3VwZGF0ZS9Ecm9wRGF0YWJhc2VEaXNjb3ZlcnlSdWxlU3RhdGVtZW50VXBkYXRlci5qYXZh) | `87.50% <ø> (-0.74%)` | :arrow_down: |
   | [...api/ingest/position/PrimaryKeyPositionFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYXRhL3BpcGVsaW5lL2FwaS9pbmdlc3QvcG9zaXRpb24vUHJpbWFyeUtleVBvc2l0aW9uRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...hm/DataMatchDataConsistencyCalculateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2NvbnNpc3RlbmN5L2FsZ29yaXRobS9EYXRhTWF0Y2hEYXRhQ29uc2lzdGVuY3lDYWxjdWxhdGVBbGdvcml0aG0uamF2YQ==) | `27.41% <0.00%> (-0.23%)` | :arrow_down: |
   | [...re/check/datasource/AbstractDataSourceChecker.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2NoZWNrL2RhdGFzb3VyY2UvQWJzdHJhY3REYXRhU291cmNlQ2hlY2tlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ata/pipeline/core/importer/DataSourceImporter.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2ltcG9ydGVyL0RhdGFTb3VyY2VJbXBvcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ine/core/ingest/dumper/BasicColumnValueReader.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2luZ2VzdC9kdW1wZXIvQmFzaWNDb2x1bW5WYWx1ZVJlYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...a/pipeline/core/ingest/dumper/InventoryDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2luZ2VzdC9kdW1wZXIvSW52ZW50b3J5RHVtcGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...ml/YamlJobItemIncrementalTasksProgressSwapper.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL2pvYi9wcm9ncmVzcy95YW1sL1lhbWxKb2JJdGVtSW5jcmVtZW50YWxUYXNrc1Byb2dyZXNzU3dhcHBlci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [.../core/metadata/generator/PipelineDDLGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a2VybmVsL2RhdGEtcGlwZWxpbmUvY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGF0YS9waXBlbGluZS9jb3JlL21ldGFkYXRhL2dlbmVyYXRvci9QaXBlbGluZURETEdlbmVyYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
   | ... and [76 more](https://codecov.io/gh/apache/shardingsphere/pull/24275?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org