[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #860: [#859][Improvement] Set MALLOC_ARENA_MAX in start-shuffle-server.sh

["jerqi (via GitHub)" <gi...@apache.org>]

jerqi commented on code in PR #860:
URL: https://github.com/apache/incubator-uniffle/pull/860#discussion_r1189469470


##########
bin/start-shuffle-server.sh:
##########
@@ -41,6 +41,12 @@ if [ -n "${RSS_IP:-}" ]; then
   echo "Shuffle Server RSS_IP: ${RSS_IP}"
 fi
 
+# glibc use an arena memory allocator that causes virtual
+# memory usage to explode. This interacts badly
+# with the many threads that we use in rss. Tune the variable
+# down to prevent vmem explosion. Default value is 8 * CORES.
+export MALLOC_ARENA_MAX=${MALLOC_ARENA_MAX:-4}

Review Comment:
   Why do we choose `4` as our default value?
   The comment is a little misunderstanding.
   ```
   Default value is 8 * CORES
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org