[GitHub] [flink] ifndef-SleePy commented on a change in pull request #10332: [FLINK-13905][checkpointing] Separate checkpoint triggering into several asynchronous stages

[GitBox <gi...@apache.org>]

ifndef-SleePy commented on a change in pull request #10332: [FLINK-13905][checkpointing] Separate checkpoint triggering into several asynchronous stages
URL: https://github.com/apache/flink/pull/10332#discussion_r363101375
 
 

 ##########
 File path: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
 ##########
 @@ -162,9 +162,9 @@
 	 * Non-volatile, because only accessed in synchronized scope */
 	private boolean periodicScheduling;
 
-	/** Flag whether a trigger request could not be handled immediately. Non-volatile, because only
-	 * accessed in synchronized scope */
-	private boolean triggerRequestQueued;
+	/** Flag whether periodic triggering is suspended (too many concurrent pending checkpoint).
+	 * Non-volatile, because only accessed in synchronized scope */
+	private boolean periodicTriggeringSuspended;
 
 Review comment:
   OK let me explain more about the background.
   1. I want to introduce a queue to cache those trigger requests that can't be triggered for now. Because there is an asynchronous in-flight trigger. This is described in last commit.
   2. I found there is already a queue logic existing, `triggerRequestQueued`.
   3. I tried to unify these two queuing concepts. But I found it makes things much more complicated. It's hard to understand or maintain the queuing logic without this background. I believe it's more reasonable to keep both these queuing concepts separately.
   4. I renamed the `triggerRequestQueued` to `periodicTriggeringSuspended` to distinguish these two concepts. I think the `triggerRequestQueued` relevant concept is not correct somewhat. It does not really queue the trigger request but fail it and suspend the periodic triggering instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services