You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/22 09:39:38 UTC
[GitHub] [cordova-docs] NiklasMerz opened a new pull request #1062:
doc(CONTRIBUTING): Remove text about JIRA and ICLA
NiklasMerz opened a new pull request #1062: doc(CONTRIBUTING): Remove text about JIRA and ICLA
URL: https://github.com/apache/cordova-docs/pull/1062
...add .vscode for users to avoid checking that in
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Contributing docs
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
This PR removes old information from the Contributing doc. AFAIK an ICLA is not required for trivial contributions, JIRA has been discontinued for Cordova.
### Testing
<!-- Please describe in detail how you tested your changes. -->
npm test
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-docs] NiklasMerz commented on issue #1062:
doc(CONTRIBUTING): Remove text about JIRA and ICLA
Posted by GitBox <gi...@apache.org>.
NiklasMerz commented on issue #1062: doc(CONTRIBUTING): Remove text about JIRA and ICLA
URL: https://github.com/apache/cordova-docs/pull/1062#issuecomment-589976633
@purplecabbage Thanks for pointing that out. I was just checking how to do some things in docs and this file did not help or make any sense to me at the moment.
I just checkend and all repos use the exact same file. So changing this should be something global. Closing this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-docs] NiklasMerz closed pull request #1062:
doc(CONTRIBUTING): Remove text about JIRA and ICLA
Posted by GitBox <gi...@apache.org>.
NiklasMerz closed pull request #1062: doc(CONTRIBUTING): Remove text about JIRA and ICLA
URL: https://github.com/apache/cordova-docs/pull/1062
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-docs] purplecabbage commented on issue #1062:
doc(CONTRIBUTING): Remove text about JIRA and ICLA
Posted by GitBox <gi...@apache.org>.
purplecabbage commented on issue #1062: doc(CONTRIBUTING): Remove text about JIRA and ICLA
URL: https://github.com/apache/cordova-docs/pull/1062#issuecomment-589973970
I would keep the iCLA text, but mention it is ‘recommended, only required for more substantial contributions’
Instead of removing jira issue link why not recommend they create a gh-issue in the relevant repo?
Jira is still required for security issues as we cannot make private gh-issues
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org