You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/13 18:00:30 UTC
[GitHub] [hbase] HorizonNet opened a new pull request #1030: HBASE-23621
Reduced the number of Checkstyle violations in tests of hbase-common
HorizonNet opened a new pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030
Backport of #967 to branch-1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-574366915
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 19s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 54s | branch-1 passed |
| +1 :green_heart: | compile | 1m 16s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 1m 10s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 2m 20s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 5s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 50s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 1m 5s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 2m 52s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 0s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 1m 1s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 1m 1s | the patch passed |
| +1 :green_heart: | compile | 1m 10s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 1m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 30s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 55s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 19s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 11s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 1m 4s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | findbugs | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 32s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 122m 22s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 43s | The patch does not generate ASF License warnings. |
| | | 175m 40s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 020f380c5af0 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / b5d0da7 |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/3/testReport/ |
| Max. process+thread count | 3935 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/3/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1030:
HBASE-23621 Reduced the number of Checkstyle violations in tests of
hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#discussion_r367288802
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestEncryption.java
##########
@@ -1,22 +1,24 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with this
- * work for additional information regarding copyright ownership. The ASF
- * licenses this file to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
+/**
Review comment:
Fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-575664031
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 48s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 54s | branch-1 passed |
| +1 :green_heart: | compile | 1m 22s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 1m 30s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 2m 43s | branch-1 passed |
| +1 :green_heart: | shadedjars | 4m 4s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 4s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 17s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 3m 46s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 5m 13s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 22s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 20s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 1m 20s | the patch passed |
| +1 :green_heart: | compile | 1m 33s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 1m 33s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 35s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 59s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 44s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 6m 23s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 1m 1s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 4m 48s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 52s | hbase-common in the patch passed. |
| -1 :x: | unit | 157m 26s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 47s | The patch does not generate ASF License warnings. |
| | | 220m 57s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint |
| | hadoop.hbase.master.TestWarmupRegion |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/6/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 40729bbdb814 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / d466f77 |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/6/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/6/testReport/ |
| Max. process+thread count | 5071 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/6/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-573881666
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 29s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 20s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 29s | branch-1 passed |
| +1 :green_heart: | compile | 1m 2s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 1m 10s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 2m 24s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 13s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 54s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 1m 6s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 2m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 3s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 11s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | compile | 1m 9s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 1m 9s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 49s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 8s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 20s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 1m 6s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | findbugs | 4m 23s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 33s | hbase-common in the patch passed. |
| -1 :x: | unit | 155m 46s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 50s | The patch does not generate ASF License warnings. |
| | | 209m 17s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.client.replication.TestReplicationAdminWithClusters |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux e15ecf3b98b5 4.15.0-70-generic #79-Ubuntu SMP Tue Nov 12 10:36:11 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / 248d80b |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/testReport/ |
| Max. process+thread count | 3830 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-575161963
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 40s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 32s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 8m 1s | branch-1 passed |
| +1 :green_heart: | compile | 1m 17s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 1m 22s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 2m 36s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 49s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 21s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 3m 24s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 43s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 13s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 1m 13s | the patch passed |
| +1 :green_heart: | compile | 1m 31s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 1m 31s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 34s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 56s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 48s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 6m 1s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 1m 2s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 16s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 4m 54s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 53s | hbase-common in the patch passed. |
| -1 :x: | unit | 157m 50s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. |
| | | 218m 32s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint |
| | hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles |
| | hadoop.hbase.master.balancer.TestStochasticLoadBalancer2 |
| | hadoop.hbase.mapreduce.TestLoadIncrementalHFiles |
| | hadoop.hbase.master.TestMasterBalanceThrottling |
| | hadoop.hbase.mapreduce.TestTableSnapshotInputFormat |
| | hadoop.hbase.master.TestWarmupRegion |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux c3a6b5d7e2f4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / 99a328f |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/testReport/ |
| Max. process+thread count | 5081 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/5/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1030:
HBASE-23621 Reduced the number of Checkstyle violations in tests of
hbase-common
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#discussion_r370707794
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/util/RedundantKVGenerator.java
##########
@@ -140,46 +139,45 @@ public RedundantKVGenerator(Random randomizer,
private Random randomizer;
// row settings
- private byte[] commonPrefix;//global prefix before rowPrefixes
+ private byte[] commonPrefix; //global prefix before rowPrefixes
private int numberOfRowPrefixes;
- private int averagePrefixLength = 6;
- private int prefixLengthVariance = 3;
- private int averageSuffixLength = 3;
- private int suffixLengthVariance = 3;
- private int numberOfRows = 500;
+ private int averagePrefixLength;
+ private int prefixLengthVariance;
+ private int averageSuffixLength;
+ private int suffixLengthVariance;
+ private int numberOfRows;
- //family
+ // family
private byte[] family;
// qualifier
- private float chanceForSameQualifier = 0.5f;
- private float chanceForSimilarQualifier = 0.4f;
- private int averageQualifierLength = 9;
- private int qualifierLengthVariance = 3;
+ private float chanceForSameQualifier;
+ private float chanceForSimilarQualifier;
+ private int averageQualifierLength;
+ private int qualifierLengthVariance;
- private int columnFamilyLength = 9;
- private int valueLength = 8;
- private float chanceForZeroValue = 0.5f;
+ private int columnFamilyLength;
+ private int valueLength;
+ private float chanceForZeroValue;
- private int baseTimestampDivide = 1000000;
- private int timestampDiffSize = 100000000;
+ private int baseTimestampDivide;
+ private int timestampDiffSize;
Review comment:
Ok. Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1030:
HBASE-23621 Reduced the number of Checkstyle violations in tests of
hbase-common
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#discussion_r370336864
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/util/RedundantKVGenerator.java
##########
@@ -140,46 +139,45 @@ public RedundantKVGenerator(Random randomizer,
private Random randomizer;
// row settings
- private byte[] commonPrefix;//global prefix before rowPrefixes
+ private byte[] commonPrefix; //global prefix before rowPrefixes
private int numberOfRowPrefixes;
- private int averagePrefixLength = 6;
- private int prefixLengthVariance = 3;
- private int averageSuffixLength = 3;
- private int suffixLengthVariance = 3;
- private int numberOfRows = 500;
+ private int averagePrefixLength;
+ private int prefixLengthVariance;
+ private int averageSuffixLength;
+ private int suffixLengthVariance;
+ private int numberOfRows;
- //family
+ // family
private byte[] family;
// qualifier
- private float chanceForSameQualifier = 0.5f;
- private float chanceForSimilarQualifier = 0.4f;
- private int averageQualifierLength = 9;
- private int qualifierLengthVariance = 3;
+ private float chanceForSameQualifier;
+ private float chanceForSimilarQualifier;
+ private int averageQualifierLength;
+ private int qualifierLengthVariance;
- private int columnFamilyLength = 9;
- private int valueLength = 8;
- private float chanceForZeroValue = 0.5f;
+ private int columnFamilyLength;
+ private int valueLength;
+ private float chanceForZeroValue;
- private int baseTimestampDivide = 1000000;
- private int timestampDiffSize = 100000000;
+ private int baseTimestampDivide;
+ private int timestampDiffSize;
Review comment:
The values are overwritten later?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
saintstack commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-578189542
I'm still +1.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on a change in pull request #1030:
HBASE-23621 Reduced the number of Checkstyle violations in tests of
hbase-common
Posted by GitBox <gi...@apache.org>.
busbey commented on a change in pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#discussion_r366973110
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/io/crypto/TestEncryption.java
##########
@@ -1,22 +1,24 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with this
- * work for additional information regarding copyright ownership. The ASF
- * licenses this file to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
+/**
Review comment:
this is a file header and not a javadoc, shouldn't it be using `/*` and not `/**`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] saintstack commented on a change in pull request #1030:
HBASE-23621 Reduced the number of Checkstyle violations in tests of
hbase-common
Posted by GitBox <gi...@apache.org>.
saintstack commented on a change in pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#discussion_r370336247
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/TestCellUtil.java
##########
@@ -221,34 +220,35 @@ public int getTagsLength() {
// TODO Auto-generated method stub
return 0;
}
- };
+ }
/**
* Was overflowing if 100k or so lists of cellscanners to return.
- * @throws IOException
*/
@Test
public void testCreateCellScannerOverflow() throws IOException {
- consume(doCreateCellScanner(1, 1), 1 * 1);
- consume(doCreateCellScanner(3, 0), 3 * 0);
+ consume(doCreateCellScanner(1, 1), 1);
+ consume(doCreateCellScanner(3, 0), 0);
Review comment:
Smile
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-574177429
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 7m 15s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 19s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 13s | branch-1 passed |
| +1 :green_heart: | compile | 0m 59s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | compile | 1m 5s | branch-1 passed with JDK v1.7.0_242 |
| +1 :green_heart: | checkstyle | 2m 5s | branch-1 passed |
| +1 :green_heart: | shadedjars | 2m 52s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 54s | branch-1 passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 1m 3s | branch-1 passed with JDK v1.7.0_242 |
| +0 :ok: | spotbugs | 2m 58s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 7s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 2s | the patch passed |
| +1 :green_heart: | compile | 0m 57s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javac | 0m 58s | the patch passed |
| +1 :green_heart: | compile | 1m 13s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | javac | 1m 13s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 31s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 37s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 2m 42s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 4s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed with JDK v1.8.0_232 |
| +1 :green_heart: | javadoc | 1m 5s | the patch passed with JDK v1.7.0_242 |
| +1 :green_heart: | findbugs | 4m 17s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 43s | hbase-common in the patch passed. |
| -1 :x: | unit | 33m 59s | hbase-server in the patch failed. |
| +1 :green_heart: | asflicense | 0m 33s | The patch does not generate ASF License warnings. |
| | | 90m 48s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hbase.http.log.TestLogLevel |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux 6d369c2d403b 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / b5d0da7 |
| Default Java | 1.7.0_242 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/2/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/2/testReport/ |
| Max. process+thread count | 743 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/2/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-576822219
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 12m 22s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 29s | branch-1 passed |
| +1 :green_heart: | compile | 0m 58s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 1m 10s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 2m 19s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 15s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 55s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 5s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 2m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 1s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 2s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | compile | 1m 10s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 1m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 30s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 46s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 3s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 7s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 49s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 5s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 31s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 149m 48s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 46s | The patch does not generate ASF License warnings. |
| | | 213m 3s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux fb2e1fc0cc13 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / ee50d48 |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/testReport/ |
| Max. process+thread count | 4888 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/1/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on a change in pull request #1030:
HBASE-23621 Reduced the number of Checkstyle violations in tests of
hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on a change in pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#discussion_r370575027
##########
File path: hbase-common/src/test/java/org/apache/hadoop/hbase/util/RedundantKVGenerator.java
##########
@@ -140,46 +139,45 @@ public RedundantKVGenerator(Random randomizer,
private Random randomizer;
// row settings
- private byte[] commonPrefix;//global prefix before rowPrefixes
+ private byte[] commonPrefix; //global prefix before rowPrefixes
private int numberOfRowPrefixes;
- private int averagePrefixLength = 6;
- private int prefixLengthVariance = 3;
- private int averageSuffixLength = 3;
- private int suffixLengthVariance = 3;
- private int numberOfRows = 500;
+ private int averagePrefixLength;
+ private int prefixLengthVariance;
+ private int averageSuffixLength;
+ private int suffixLengthVariance;
+ private int numberOfRows;
- //family
+ // family
private byte[] family;
// qualifier
- private float chanceForSameQualifier = 0.5f;
- private float chanceForSimilarQualifier = 0.4f;
- private int averageQualifierLength = 9;
- private int qualifierLengthVariance = 3;
+ private float chanceForSameQualifier;
+ private float chanceForSimilarQualifier;
+ private int averageQualifierLength;
+ private int qualifierLengthVariance;
- private int columnFamilyLength = 9;
- private int valueLength = 8;
- private float chanceForZeroValue = 0.5f;
+ private int columnFamilyLength;
+ private int valueLength;
+ private float chanceForZeroValue;
- private int baseTimestampDivide = 1000000;
- private int timestampDiffSize = 100000000;
+ private int baseTimestampDivide;
+ private int timestampDiffSize;
Review comment:
They are both overwritten in the [constructor above](https://github.com/apache/hbase/pull/1030/files#diff-23663981b4ae838887df2503fa0586ccR113).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-575743560
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 32s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 1m 21s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 30s | branch-1 passed |
| +1 :green_heart: | compile | 0m 59s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | compile | 1m 9s | branch-1 passed with JDK v1.7.0_252 |
| +1 :green_heart: | checkstyle | 2m 21s | branch-1 passed |
| +1 :green_heart: | shadedjars | 3m 13s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 0m 55s | branch-1 passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 6s | branch-1 passed with JDK v1.7.0_252 |
| +0 :ok: | spotbugs | 2m 51s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| +1 :green_heart: | findbugs | 4m 2s | branch-1 passed |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 5s | the patch passed |
| +1 :green_heart: | compile | 0m 59s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javac | 0m 59s | the patch passed |
| +1 :green_heart: | compile | 1m 10s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | javac | 1m 10s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 30s | hbase-common: The patch generated 0 new + 20 unchanged - 32 fixed = 20 total (was 52) |
| +1 :green_heart: | checkstyle | 1m 46s | hbase-server: The patch generated 0 new + 330 unchanged - 1 fixed = 330 total (was 331) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | shadedjars | 3m 5s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | hadoopcheck | 5m 14s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. |
| +1 :green_heart: | javadoc | 0m 48s | the patch passed with JDK v1.8.0_242 |
| +1 :green_heart: | javadoc | 1m 4s | the patch passed with JDK v1.7.0_252 |
| +1 :green_heart: | findbugs | 4m 20s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 2m 31s | hbase-common in the patch passed. |
| +1 :green_heart: | unit | 141m 5s | hbase-server in the patch passed. |
| +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. |
| | | 193m 43s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/7/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux a610891b9b7b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / d466f77 |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/7/testReport/ |
| Max. process+thread count | 4996 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/7/console |
| versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet merged pull request #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
HorizonNet merged pull request #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1030: HBASE-23621 Reduced
the number of Checkstyle violations in tests of hbase-common
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1030: HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common
URL: https://github.com/apache/hbase/pull/1030#issuecomment-575051375
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 14m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 11 new or modified test files. |
||| _ branch-1 Compile Tests _ |
| +0 :ok: | mvndep | 0m 6s | Maven dependency ordering for branch |
| -1 :x: | mvninstall | 0m 7s | root in branch-1 failed. |
| -1 :x: | compile | 0m 6s | hbase-common in branch-1 failed with JDK v1.8.0_242. |
| -1 :x: | compile | 0m 6s | hbase-server in branch-1 failed with JDK v1.8.0_242. |
| -1 :x: | compile | 0m 7s | hbase-common in branch-1 failed with JDK v1.7.0_252. |
| -1 :x: | compile | 0m 6s | hbase-server in branch-1 failed with JDK v1.7.0_252. |
| -1 :x: | checkstyle | 0m 5s | The patch fails to run checkstyle in hbase-common |
| -1 :x: | checkstyle | 0m 4s | The patch fails to run checkstyle in hbase-server |
| -1 :x: | shadedjars | 0m 4s | branch has 11 errors when building our shaded downstream artifacts. |
| -1 :x: | javadoc | 0m 5s | hbase-common in branch-1 failed with JDK v1.8.0_242. |
| -1 :x: | javadoc | 0m 6s | hbase-server in branch-1 failed with JDK v1.8.0_242. |
| -1 :x: | javadoc | 0m 6s | hbase-common in branch-1 failed with JDK v1.7.0_252. |
| -1 :x: | javadoc | 0m 6s | hbase-server in branch-1 failed with JDK v1.7.0_252. |
| +0 :ok: | spotbugs | 0m 42s | Used deprecated FindBugs config; considering switching to SpotBugs. |
| -1 :x: | findbugs | 0m 6s | hbase-common in branch-1 failed. |
| -1 :x: | findbugs | 0m 7s | hbase-server in branch-1 failed. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 5s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 7s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | hbase-common in the patch failed with JDK v1.8.0_242. |
| -1 :x: | compile | 0m 5s | hbase-server in the patch failed with JDK v1.8.0_242. |
| -1 :x: | javac | 0m 6s | hbase-common in the patch failed with JDK v1.8.0_242. |
| -1 :x: | javac | 0m 5s | hbase-server in the patch failed with JDK v1.8.0_242. |
| -1 :x: | compile | 0m 7s | hbase-common in the patch failed with JDK v1.7.0_252. |
| -1 :x: | compile | 0m 6s | hbase-server in the patch failed with JDK v1.7.0_252. |
| -1 :x: | javac | 0m 7s | hbase-common in the patch failed with JDK v1.7.0_252. |
| -1 :x: | javac | 0m 6s | hbase-server in the patch failed with JDK v1.7.0_252. |
| -1 :x: | checkstyle | 0m 4s | The patch fails to run checkstyle in hbase-common |
| -1 :x: | checkstyle | 0m 4s | The patch fails to run checkstyle in hbase-server |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| -1 :x: | shadedjars | 0m 5s | patch has 11 errors when building our shaded downstream artifacts. |
| -1 :x: | hadoopcheck | 0m 5s | The patch causes 11 errors with Hadoop v2.8.5. |
| -1 :x: | hadoopcheck | 0m 10s | The patch causes 11 errors with Hadoop v2.9.2. |
| -1 :x: | javadoc | 0m 6s | hbase-common in the patch failed with JDK v1.8.0_242. |
| -1 :x: | javadoc | 0m 5s | hbase-server in the patch failed with JDK v1.8.0_242. |
| -1 :x: | javadoc | 0m 7s | hbase-common in the patch failed with JDK v1.7.0_252. |
| -1 :x: | javadoc | 0m 6s | hbase-server in the patch failed with JDK v1.7.0_252. |
| -1 :x: | findbugs | 0m 6s | hbase-common in the patch failed. |
| -1 :x: | findbugs | 0m 7s | hbase-server in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 7s | hbase-common in the patch failed. |
| -1 :x: | unit | 0m 6s | hbase-server in the patch failed. |
| +0 :ok: | asflicense | 0m 13s | ASF License check generated no output? |
| | | 19m 12s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1030 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile |
| uname | Linux dc8f41001d12 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/precommit/personality/provided.sh |
| git revision | branch-1 / 907184d |
| Default Java | 1.7.0_252 |
| Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252 |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-compile-hbase-common-jdk1.8.0_242.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-compile-hbase-server-jdk1.8.0_242.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-compile-hbase-common-jdk1.7.0_252.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-compile-hbase-server-jdk1.7.0_252.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/maven-branch-checkstyle-hbase-common.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/maven-branch-checkstyle-hbase-server.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-shadedjars.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-javadoc-hbase-common-jdk1.8.0_242.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-javadoc-hbase-server-jdk1.8.0_242.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-javadoc-hbase-common-jdk1.7.0_252.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-javadoc-hbase-server-jdk1.7.0_252.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-findbugs-hbase-common.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/branch-findbugs-hbase-server.txt |
| mvninstall | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-mvninstall-root.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-common-jdk1.8.0_242.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-server-jdk1.8.0_242.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-common-jdk1.8.0_242.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-server-jdk1.8.0_242.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-common-jdk1.7.0_252.txt |
| compile | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-server-jdk1.7.0_252.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-common-jdk1.7.0_252.txt |
| javac | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-compile-hbase-server-jdk1.7.0_252.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/maven-patch-checkstyle-hbase-common.txt |
| checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out//home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1030/out/maven-patch-checkstyle-hbase-server.txt |
| shadedjars | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-shadedjars.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-javac-2.8.5.txt |
| hadoopcheck | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-javac-2.9.2.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-javadoc-hbase-common-jdk1.8.0_242.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-javadoc-hbase-server-jdk1.8.0_242.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-javadoc-hbase-common-jdk1.7.0_252.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-javadoc-hbase-server-jdk1.7.0_252.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-findbugs-hbase-common.txt |
| findbugs | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-findbugs-hbase-server.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-unit-hbase-common.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/artifact/out/patch-unit-hbase-server.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/testReport/ |
| Max. process+thread count | 42 (vs. ulimit of 10000) |
| modules | C: hbase-common hbase-server U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1030/4/console |
| versions | git=1.9.1 maven=3.0.5 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services