You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/10 06:02:52 UTC
[GitHub] [apisix-dashboard] idbeta opened a new pull request #982: add frontend e2e test for create route
idbeta opened a new pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982
fixed #975
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Frontend E2E test
- [ ] New feature provided
- [ ] Improve performance
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (74b0db1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...74b0db1](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (87ae02a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.49% +0.07%
==========================================
Files 18 18
Lines 1299 1299
==========================================
+ Hits 564 565 +1
+ Misses 643 642 -1
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...87ae02a](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis removed a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
membphis removed a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-741712682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742200333
One PR one thing.
I think the PR needs to be split into two PRs.
1. add create route E2E test
2. modify the YAML file to start the local manager-api for test .
What do you think? @membphis @juzhiyuan @idbeta
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740462477
> why e2e test cases in “src” dir？
I wrote the use case based on this [document](https://github.com/apache/apisix-dashboard/blob/master/web/src/e2e/README.md), it seems a little strange. @LiteSun please answer this when you are free
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (099020b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/26e40ca8c3388f38331466cf9d09d8e9f6009010?el=desc) (26e40ca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.96% 44.04% +0.07%
==========================================
Files 18 18
Lines 1310 1310
==========================================
+ Hits 576 577 +1
+ Misses 643 642 -1
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [26e40ca...099020b](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740482256
> > why e2e test cases in “src” dir？
this is unacceptable. we need to change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539804242
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
Review comment:
agree, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (893a949) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...893a949](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (7946716) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 44.04% +0.62%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 577 +13
+ Misses 643 642 -1
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...7946716](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta closed pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta closed pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742178286
> ready for review?
I want to try the `delete route` action again
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539869378
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ inputRoutename: '#name',
+ inputRoutepath: '#uris_0',
+ inputNodehost: '#nodes_0_host',
+ inputNodeport: '#nodes_0_port',
+ inputNodeweight: '#nodes_0_weight',
+ routeList: '.ant-layout-sider-children ul li:nth-child(2)',
+ buttonCreateroute: '.ant-pro-table-toolbar-option button',
+ buttonNext: '.ant-row-end .ant-col:nth-child(2)',
+ successIco: '.ant-result-success .anticon-check-circle',
+ buttonReturnRoutelist: '.ant-result-extra .ant-btn-primary'
+};
+
Review comment:
please take a look at https://github.com/getgauge/taiko
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539804113
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
+ input_routepath: '#uris_0',
+ input_node_host: '#nodes_0_host',
+ input_node_port: '#nodes_0_port',
+ input_node_weight: '#nodes_0_weight',
+ route_list: '.ant-layout-sider-children ul li:nth-child(2)',
+ button_createroute: '.ant-pro-table-toolbar-option button',
+ button_next: '.ant-row-end .ant-col:nth-child(2)',
+ success_ico: '.ant-result-success .anticon-check-circle',
+ button_return_routelist: '.ant-result-extra .ant-btn-primary'
+};
+
+describe('Route test', () => {
+
+ beforeAll(async () => {
+ browser = await puppeteer.launch({
+ headless: true,
+ slowMo: 100
+ });
+ });
+
+ test('create route', async () => {
+ const page = await browser.newPage();
+ await setupLogin(page);
+ // access route list page
+ await page.waitForSelector(domSelectors.route_list)
+ await page.click(domSelectors.route_list)
+ await page.content();
+ // create route
+ await page.waitForSelector(domSelectors.button_createroute)
+ await page.click(domSelectors.button_createroute)
+ await page.content();
+
+ await page.waitForSelector(domSelectors.input_routename);
Review comment:
fixed.
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
+ input_routepath: '#uris_0',
+ input_node_host: '#nodes_0_host',
+ input_node_port: '#nodes_0_port',
+ input_node_weight: '#nodes_0_weight',
+ route_list: '.ant-layout-sider-children ul li:nth-child(2)',
+ button_createroute: '.ant-pro-table-toolbar-option button',
+ button_next: '.ant-row-end .ant-col:nth-child(2)',
+ success_ico: '.ant-result-success .anticon-check-circle',
+ button_return_routelist: '.ant-result-extra .ant-btn-primary'
+};
+
+describe('Route test', () => {
+
+ beforeAll(async () => {
+ browser = await puppeteer.launch({
+ headless: true,
+ slowMo: 100
+ });
+ });
+
+ test('create route', async () => {
+ const page = await browser.newPage();
+ await setupLogin(page);
+ // access route list page
+ await page.waitForSelector(domSelectors.route_list)
+ await page.click(domSelectors.route_list)
+ await page.content();
+ // create route
+ await page.waitForSelector(domSelectors.button_createroute)
+ await page.click(domSelectors.button_createroute)
+ await page.content();
+
+ await page.waitForSelector(domSelectors.input_routename);
+ await page.type(domSelectors.input_routename, "test_route_by_ui_autotest");
+ await page.focus(domSelectors.input_routepath);
+ await page.keyboard.press( 'Backspace' );
+ await page.keyboard.press( 'Backspace' );
+ await page.type(domSelectors.input_routepath, "/testpath_by_ui_autotest");
+ await page.click(domSelectors.button_next);
+
+ await page.waitForSelector(domSelectors.input_node_host);
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on a change in pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539229571
##########
File path: .github/workflows/frontend-e2e-test.yml
##########
@@ -31,9 +41,20 @@ jobs:
with:
node-version: 14.x
- - name: Install dependencies
+ - name: Setup golang environment
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+
+ - name: Start manager-api
+ working-directory: ./
Review comment:
how about this way?
```
working-directory: ./api
run: nohup go run . &
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
+ input_routepath: '#uris_0',
+ input_node_host: '#nodes_0_host',
+ input_node_port: '#nodes_0_port',
+ input_node_weight: '#nodes_0_weight',
+ route_list: '.ant-layout-sider-children ul li:nth-child(2)',
+ button_createroute: '.ant-pro-table-toolbar-option button',
+ button_next: '.ant-row-end .ant-col:nth-child(2)',
+ success_ico: '.ant-result-success .anticon-check-circle',
+ button_return_routelist: '.ant-result-extra .ant-btn-primary'
+};
+
+describe('Route test', () => {
+
+ beforeAll(async () => {
+ browser = await puppeteer.launch({
+ headless: true,
+ slowMo: 100
+ });
+ });
+
+ test('create route', async () => {
+ const page = await browser.newPage();
+ await setupLogin(page);
+ // access route list page
+ await page.waitForSelector(domSelectors.route_list)
+ await page.click(domSelectors.route_list)
+ await page.content();
+ // create route
+ await page.waitForSelector(domSelectors.button_createroute)
+ await page.click(domSelectors.button_createroute)
+ await page.content();
+
+ await page.waitForSelector(domSelectors.input_routename);
+ await page.type(domSelectors.input_routename, "test_route_by_ui_autotest");
+ await page.focus(domSelectors.input_routepath);
+ await page.keyboard.press( 'Backspace' );
+ await page.keyboard.press( 'Backspace' );
+ await page.type(domSelectors.input_routepath, "/testpath_by_ui_autotest");
+ await page.click(domSelectors.button_next);
+
+ await page.waitForSelector(domSelectors.input_node_host);
Review comment:
ditto
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
+ input_routepath: '#uris_0',
+ input_node_host: '#nodes_0_host',
+ input_node_port: '#nodes_0_port',
+ input_node_weight: '#nodes_0_weight',
+ route_list: '.ant-layout-sider-children ul li:nth-child(2)',
+ button_createroute: '.ant-pro-table-toolbar-option button',
+ button_next: '.ant-row-end .ant-col:nth-child(2)',
+ success_ico: '.ant-result-success .anticon-check-circle',
+ button_return_routelist: '.ant-result-extra .ant-btn-primary'
+};
+
+describe('Route test', () => {
+
+ beforeAll(async () => {
+ browser = await puppeteer.launch({
+ headless: true,
+ slowMo: 100
+ });
+ });
+
+ test('create route', async () => {
+ const page = await browser.newPage();
+ await setupLogin(page);
+ // access route list page
+ await page.waitForSelector(domSelectors.route_list)
+ await page.click(domSelectors.route_list)
+ await page.content();
+ // create route
+ await page.waitForSelector(domSelectors.button_createroute)
+ await page.click(domSelectors.button_createroute)
+ await page.content();
+
+ await page.waitForSelector(domSelectors.input_routename);
Review comment:
need a comment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta closed pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta closed pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (ae5eb85) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/26e40ca8c3388f38331466cf9d09d8e9f6009010?el=desc) (26e40ca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.96% 44.04% +0.07%
==========================================
Files 18 18
Lines 1310 1310
==========================================
+ Hits 576 577 +1
+ Misses 643 642 -1
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [26e40ca...ae5eb85](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742256783
There is a new frontend E2E test technology solution that needs to be evaluated. After the evaluation, I will decide whether to open this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539783207
##########
File path: .github/workflows/frontend-e2e-test.yml
##########
@@ -31,9 +41,20 @@ jobs:
with:
node-version: 14.x
- - name: Install dependencies
+ - name: Setup golang environment
+ uses: actions/setup-go@v1
+ with:
+ go-version: '1.13'
+
+ - name: Start manager-api
+ working-directory: ./
Review comment:
agree, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (69768f6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...69768f6](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (0bcc9b7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 44.04% +0.62%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 577 +13
+ Misses 643 642 -1
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...0bcc9b7](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-742188134
welcome review @LiteSun @moonming @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r538041881
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin,
+ BASE_URL
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
+ input_routepath: '#uris_0',
+ input_node_host: '#nodes_0_host',
+ input_node_port: '#nodes_0_port',
+ input_node_weight: '#nodes_0_weight',
+ routelist:'.ant-layout-sider-children ul li:nth-child(2)',
+ button_createroute:'.ant-pro-table-toolbar-option button',
+ button_next:'.ant-row-end .ant-col:nth-child(2)'
+};
+
+describe('Route', () => {
+
+ beforeAll(async () => {
+ browser = await puppeteer.launch({
+ headless: false,
Review comment:
why not headless？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r538126421
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin,
+ BASE_URL
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
+ input_routepath: '#uris_0',
+ input_node_host: '#nodes_0_host',
+ input_node_port: '#nodes_0_port',
+ input_node_weight: '#nodes_0_weight',
+ routelist:'.ant-layout-sider-children ul li:nth-child(2)',
+ button_createroute:'.ant-pro-table-toolbar-option button',
+ button_next:'.ant-row-end .ant-col:nth-child(2)'
+};
+
+describe('Route', () => {
+
+ beforeAll(async () => {
+ browser = await puppeteer.launch({
+ headless: false,
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (4de8f32) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 44.04% +0.62%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 577 +13
+ Misses 643 642 -1
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...4de8f32](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-741712682
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta closed pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta closed pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (c9b0563) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/26e40ca8c3388f38331466cf9d09d8e9f6009010?el=desc) (26e40ca) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.96% 44.04% +0.07%
==========================================
Files 18 18
Lines 1310 1310
==========================================
+ Hits 576 577 +1
+ Misses 643 642 -1
Partials 91 91
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [26e40ca...c9b0563](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539795869
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ input_routename: '#name',
Review comment:
```suggestion
inputRouteName: '#name',
```
please use CamelCase to keep same style.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r541524063
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ inputRoutename: '#name',
+ inputRoutepath: '#uris_0',
+ inputNodehost: '#nodes_0_host',
+ inputNodeport: '#nodes_0_port',
+ inputNodeweight: '#nodes_0_weight',
+ routeList: '.ant-layout-sider-children ul li:nth-child(2)',
+ buttonCreateroute: '.ant-pro-table-toolbar-option button',
+ buttonNext: '.ant-row-end .ant-col:nth-child(2)',
+ successIco: '.ant-result-success .anticon-check-circle',
+ buttonReturnRoutelist: '.ant-result-extra .ant-btn-primary'
+};
+
Review comment:
> please take a look at https://github.com/getgauge/taiko
ok, will try to find a better way. refer issue: https://github.com/apache/apisix-dashboard/issues/1036
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
moonming commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740381246
why e2e test cases in “src” dir？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (2fbfbc3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
=======================================
Coverage 43.41% 43.41%
=======================================
Files 18 18
Lines 1299 1299
=======================================
Hits 564 564
Misses 643 643
Partials 92 92
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...2fbfbc3](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (1e6e624) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...1e6e624](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #982: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#discussion_r539851684
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ inputRoutename: '#name',
+ inputRoutepath: '#uris_0',
+ inputNodehost: '#nodes_0_host',
+ inputNodeport: '#nodes_0_port',
+ inputNodeweight: '#nodes_0_weight',
+ routeList: '.ant-layout-sider-children ul li:nth-child(2)',
+ buttonCreateroute: '.ant-pro-table-toolbar-option button',
+ buttonNext: '.ant-row-end .ant-col:nth-child(2)',
+ successIco: '.ant-result-success .anticon-check-circle',
+ buttonReturnRoutelist: '.ant-result-extra .ant-btn-primary'
+};
+
Review comment:
For me these are too difficult to maintain
##########
File path: web/src/e2e/Route.e2e.js
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/* eslint-disable import/no-extraneous-dependencies */
+const puppeteer = require('puppeteer');
+
+const {
+ setupLogin
+} = require('./service')
+
+let browser;
+const domSelectors = {
+ inputRoutename: '#name',
+ inputRoutepath: '#uris_0',
+ inputNodehost: '#nodes_0_host',
+ inputNodeport: '#nodes_0_port',
+ inputNodeweight: '#nodes_0_weight',
+ routeList: '.ant-layout-sider-children ul li:nth-child(2)',
+ buttonCreateroute: '.ant-pro-table-toolbar-option button',
+ buttonNext: '.ant-row-end .ant-col:nth-child(2)',
+ successIco: '.ant-result-success .anticon-check-circle',
+ buttonReturnRoutelist: '.ant-result-extra .ant-btn-primary'
+};
+
Review comment:
we need to find a better way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] idbeta edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
idbeta edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740462477
> why e2e test cases in “src” dir？
I wrote the case based on this [document](https://github.com/apache/apisix-dashboard/blob/master/web/src/e2e/README.md), it seems a little strange. @LiteSun please answer this when you are free
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (f827cb2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...f827cb2](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (915e1e0) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/26e40ca8c3388f38331466cf9d09d8e9f6009010?el=desc) (26e40ca) will **decrease** coverage by `0.47%`.
> The diff coverage is `80.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
- Coverage 43.96% 43.49% -0.48%
==========================================
Files 18 18
Lines 1310 1299 -11
==========================================
- Hits 576 565 -11
+ Misses 643 642 -1
- Partials 91 92 +1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `58.04% <80.00%> (-3.65%)` | :arrow_down: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [26e40ca...915e1e0](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (eb1f223) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...eb1f223](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (198aac2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.62%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 44.04% +0.62%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 577 +13
+ Misses 643 642 -1
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...198aac2](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740504180
> why e2e test cases in “src” dir？
https://github.com/ant-design/ant-design-pro/tree/master/src/e2e
The frontend's structure is according to Ant Design Pro.
cc @membphis @moonming
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #982: draft: add frontend e2e test for create route
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #982:
URL: https://github.com/apache/apisix-dashboard/pull/982#issuecomment-740400550
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=h1) Report
> Merging [#982](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=desc) (8b7488a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8976cca55972b7ba8686843bd51241cbc3e1554c?el=desc) (8976cca) will **increase** coverage by `0.55%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.41% 43.96% +0.55%
==========================================
Files 18 18
Lines 1299 1310 +11
==========================================
+ Hits 564 576 +12
Misses 643 643
+ Partials 92 91 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/982/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `61.68% <0.00%> (+3.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=footer). Last update [8976cca...893a949](https://codecov.io/gh/apache/apisix-dashboard/pull/982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org