You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Rong-En Fan (JIRA)" <ji...@apache.org> on 2008/06/17 05:29:45 UTC

[jira] Created: (HBASE-693) TestGet2::testGetClosestRowBefore() failed with NPE after HADOOP-3472

TestGet2::testGetClosestRowBefore() failed with NPE after HADOOP-3472
---------------------------------------------------------------------

                 Key: HBASE-693
                 URL: https://issues.apache.org/jira/browse/HBASE-693
             Project: Hadoop HBase
          Issue Type: Bug
          Components: regionserver
    Affects Versions: 0.2.0
         Environment: hadoop 0.17.0 + HADOOP-3472, HBase latest trunk
            Reporter: Rong-En Fan


After HADOOP-3472, MapFile.getClosest(.., ..., true) gives the correct value.
In the unit test, we have 

10
20
30
35 <== deleted
40 

in the MapFile. so in HStore.java's rowAtOrBeforeFromMapFile(MapFile.reader, bytes, ...)

readkey = (HStoreKey)map.getClosest(searchKey, readval, true);

it gets the deleted key 35. So it can not be added into candidateKeys.
The next key is 40, which is after the search key 38. So, we ends up 
with empty candidateKeys. Therefore, we lastKey() is null. cause TestGet2.java
line 236 failed with NPE.

Since MapFile.Reader has no prev(key) method, not sure what's the best
to do in HStore.java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-693) TestGet2::testGetClosestRowBefore() failed with NPE after HADOOP-3472

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack resolved HBASE-693.
-------------------------

    Resolution: Duplicate

Closing.  Was fixed over in HBASE-716.

> TestGet2::testGetClosestRowBefore() failed with NPE after HADOOP-3472
> ---------------------------------------------------------------------
>
>                 Key: HBASE-693
>                 URL: https://issues.apache.org/jira/browse/HBASE-693
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.2.0
>         Environment: hadoop 0.17.0 + HADOOP-3472, HBase latest trunk
>            Reporter: Rong-En Fan
>             Fix For: 0.2.0
>
>
> After HADOOP-3472, MapFile.getClosest(.., ..., true) gives the correct value.
> In the unit test, we have 
> 10
> 20
> 30
> 35 <== deleted
> 40 
> in the MapFile. so in HStore.java's rowAtOrBeforeFromMapFile(MapFile.reader, bytes, ...)
> readkey = (HStoreKey)map.getClosest(searchKey, readval, true);
> it gets the deleted key 35. So it can not be added into candidateKeys.
> The next key is 40, which is after the search key 38. So, we ends up 
> with empty candidateKeys. Therefore, we lastKey() is null. cause TestGet2.java
> line 236 failed with NPE.
> Since MapFile.Reader has no prev(key) method, not sure what's the best
> to do in HStore.java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-693) TestGet2::testGetClosestRowBefore() failed with NPE after HADOOP-3472

Posted by "stack (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

stack updated HBASE-693:
------------------------

    Fix Version/s: 0.2.0

We'll trip over this issue when we add hadoop 0.17.1.  hbase 0.2 will go out with 0.17.1 at a minimum, I"m guessing, so we pick up HADOOP-3472... so we need to fix this issue for 0.2 release.  Moved this issue into 0.2.

> TestGet2::testGetClosestRowBefore() failed with NPE after HADOOP-3472
> ---------------------------------------------------------------------
>
>                 Key: HBASE-693
>                 URL: https://issues.apache.org/jira/browse/HBASE-693
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.2.0
>         Environment: hadoop 0.17.0 + HADOOP-3472, HBase latest trunk
>            Reporter: Rong-En Fan
>             Fix For: 0.2.0
>
>
> After HADOOP-3472, MapFile.getClosest(.., ..., true) gives the correct value.
> In the unit test, we have 
> 10
> 20
> 30
> 35 <== deleted
> 40 
> in the MapFile. so in HStore.java's rowAtOrBeforeFromMapFile(MapFile.reader, bytes, ...)
> readkey = (HStoreKey)map.getClosest(searchKey, readval, true);
> it gets the deleted key 35. So it can not be added into candidateKeys.
> The next key is 40, which is after the search key 38. So, we ends up 
> with empty candidateKeys. Therefore, we lastKey() is null. cause TestGet2.java
> line 236 failed with NPE.
> Since MapFile.Reader has no prev(key) method, not sure what's the best
> to do in HStore.java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.