[jira] [Commented] (AIRFLOW-4524) "Ignore All Deps" and "Ignore Task Deps" doesn't ignore task dependencies

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857443#comment-16857443 ] 

ASF GitHub Bot commented on AIRFLOW-4524:
-----------------------------------------

ashb commented on pull request #5378: [AIRFLOW-4524] Fix bug with "Ignore *" toggles in RBAC mode
URL: https://github.com/apache/airflow/pull/5378
 
 
   Make sure you have checked _all_ steps below.
   
   ### JIRA
   - [x] https://issues.apache.org/jira/browse/AIRFLOW-4524
   
   
   ### Description
   - [x] This was the result of a bad cherry-pick/backport from #5039 and I somehow introduced these three extra hidden inputs (I was trying a different solution first directly on the branch)
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> "Ignore All Deps" and "Ignore Task Deps" doesn't ignore task dependencies
> -------------------------------------------------------------------------
>
>                 Key: AIRFLOW-4524
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4524
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: ui
>    Affects Versions: 1.10.3
>            Reporter: James Meickle
>            Priority: Critical
>             Fix For: 1.10.4
>
>         Attachments: Screenshot 2019-05-16 09.15.00.png
>
>
> After an upgrade from Airflow 1.10.1->1.10.3, we're seeing this behavior when trying to "Run" a task in the UI with "Ignore All Deps" and "Ignore Task Deps":
> {code:java}
> "Could not queue task instance for execution, dependencies not met: Trigger Rule: Task's trigger rule 'all_success' requires all upstream tasks to have succeeded, but found 1 non-success(es). upstream_tasks_state={'successes': 1, 'skipped': 0, 'upstream_failed': 0, 'failed': 0, 'done': 1, 'total': 2}, upstream_task_ids={'XXX', 'XXX'}"
> {code}
> I suspected this was due to the checkbox not getting applied so I investigated this in Chrome. Here's a 1.10.3 POST (broken):
> {code:java}
> dag_id: MY_DAG_ID
> task_id: MY_TASK_ID
> execution_date: 2019-05-15T00:00:00+00:00
> origin: MY_AIRFLOW_SERVER
> ignore_all_deps: 
> ignore_ti_state: 
> ignore_task_deps: 
> ignore_all_deps: true
> ignore_task_deps: true
> downstream: true
> recursive: true
> {code}
> And here's a 1.10.1 POST (working):
> {code:java}
> task_id: MY_TASK_ID
> dag_id: MY_DAG_ID
> ignore_all_deps: true
> ignore_task_deps: true
> ignore_ti_state: false
> execution_date: 2019-05-16T11:00:00+00:00
> origin: MY_AIRFLOW_SERVER
> {code}
> It looks like the JS here is doing something wonky and sending blank values for unchecked boxes, as well as checkboxes that don't apply to the current action, which is presumably breaking parsing when the server receives a json object with multiple conflicting keys.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)