You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "tanmayrauth (via GitHub)" <gi...@apache.org> on 2026/04/28 22:10:07 UTC
[PR] fix(table): include expected vs found snapshot id in AssertRefSnapshotID errors (#940) [iceberg-go]
tanmayrauth opened a new pull request, #952:
URL: https://github.com/apache/iceberg-go/pull/952
Format ref name, expected snapshot id, and found snapshot id into all three error paths so operators can see what changed during commit conflicts. Also fixes incorrect pointer formatting with %d.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): include expected vs found snapshot id in AssertRefSnapshotID errors (#940) [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on code in PR #952:
URL: https://github.com/apache/iceberg-go/pull/952#discussion_r3164114154
##########
table/requirements.go:
##########
@@ -180,14 +180,14 @@ func (a *assertRefSnapshotID) Validate(meta Metadata) error {
if r != nil {
if a.SnapshotID == nil {
- return fmt.Errorf("requirement failed: %s %s was created concurrently", r.SnapshotRefType, a.Ref)
+ return fmt.Errorf("requirement failed: ref %q was created concurrently, found %d", a.Ref, r.SnapshotID)
Review Comment:
Why use `%q` here instead of `"%s"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): include expected vs found snapshot id in AssertRefSnapshotID errors (#940) [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on code in PR #952:
URL: https://github.com/apache/iceberg-go/pull/952#discussion_r3164475992
##########
table/requirements.go:
##########
@@ -180,14 +180,14 @@ func (a *assertRefSnapshotID) Validate(meta Metadata) error {
if r != nil {
if a.SnapshotID == nil {
- return fmt.Errorf("requirement failed: %s %s was created concurrently", r.SnapshotRefType, a.Ref)
+ return fmt.Errorf("requirement failed: ref %q was created concurrently, found %d", a.Ref, r.SnapshotID)
Review Comment:
Yeah, ref name might not have special char. Will update revert it to %s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): include expected vs found snapshot id in AssertRefSnapshotID errors (#940) [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #952:
URL: https://github.com/apache/iceberg-go/pull/952#issuecomment-4354076486
Where possible we definitely want to try to keep cross-client log parity so that's definitely a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): include expected vs found snapshot id in AssertRefSnapshotID errors (#940) [iceberg-go]
Posted by "tanmayrauth (via GitHub)" <gi...@apache.org>.
tanmayrauth commented on PR #952:
URL: https://github.com/apache/iceberg-go/pull/952#issuecomment-4346358251
@laskoviymishka @zeroshade will you be able to review this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] fix(table): include expected vs found snapshot id in AssertRefSnapshotID errors (#940) [iceberg-go]
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #952:
URL: https://github.com/apache/iceberg-go/pull/952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org