You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/06 03:45:52 UTC
[GitHub] [superset] AAfghahi opened a new pull request #16987: refactor (reports): Arash/new state report
AAfghahi opened a new pull request #16987:
URL: https://github.com/apache/superset/pull/16987
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This is the continued refactor of the Reports Modal. We are changing the way that the redux store works.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho merged pull request #16987: refactor: Arash/new state report
Posted by GitBox <gi...@apache.org>.
eschutho merged pull request #16987:
URL: https://github.com/apache/superset/pull/16987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #16987: refactor (reports): Arash/new state report
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #16987:
URL: https://github.com/apache/superset/pull/16987#issuecomment-949532654
I think something went wrong when rebasing. It's showing `899` changed files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on pull request #16987: refactor (reports): Arash/new state report
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on pull request #16987:
URL: https://github.com/apache/superset/pull/16987#issuecomment-949680433
@michael-s-molina Yeah, I rebased to master not the feature branch. Will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #16987: refactor: Arash/new state report
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #16987:
URL: https://github.com/apache/superset/pull/16987#issuecomment-954062201
Awesome, where can I learn more about the refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16987: refactor (reports): Arash/new state report
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16987:
URL: https://github.com/apache/superset/pull/16987#discussion_r724021071
##########
File path: superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
##########
@@ -49,8 +49,13 @@ export default function HeaderReportActionsDropDown({
const reports: Record<number, AlertObject> = useSelector<any, AlertObject>(
state => state.reports,
);
- const report: AlertObject = Object.values(reports)[0];
- const hasReport = !!report;
+ const report: AlertObject = Object.values(reports).filter(report => {
+ if (dashboardId) {
+ return report.dashboard_id === dashboardId;
+ }
+ return report.chart_id === chart?.id;
+ })[0];
+ console.log(report);
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #16987: refactor (reports): Arash/new state report
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #16987:
URL: https://github.com/apache/superset/pull/16987#discussion_r724021071
##########
File path: superset-frontend/src/components/ReportModal/HeaderReportActionsDropdown/index.tsx
##########
@@ -49,8 +49,13 @@ export default function HeaderReportActionsDropDown({
const reports: Record<number, AlertObject> = useSelector<any, AlertObject>(
state => state.reports,
);
- const report: AlertObject = Object.values(reports)[0];
- const hasReport = !!report;
+ const report: AlertObject = Object.values(reports).filter(report => {
+ if (dashboardId) {
+ return report.dashboard_id === dashboardId;
+ }
+ return report.chart_id === chart?.id;
+ })[0];
+ console.log(report);
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian removed a comment on pull request #16987: refactor: Arash/new state report
Posted by GitBox <gi...@apache.org>.
suddjian removed a comment on pull request #16987:
URL: https://github.com/apache/superset/pull/16987#issuecomment-954062201
Awesome, where can I learn more about the refactor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org