You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2024/01/03 12:18:41 UTC
[PR] [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 [spark]
beliefer opened a new pull request, #44577:
URL: https://github.com/apache/spark/pull/44577
### What changes were proposed in this pull request?
This PR propose to remove `ThreadLocal` due to `SecureRandom` is thread safe since JDK9.
### Why are the changes needed?
Spark already upgraded the JDK version to 17.
Before JDK9, we use `ThreadLocal` to keep the thread safe for `SecureRandom`.
There are some javadoc of `SecureRandom` since JDK9 show below.
Now, we can remove `ThreadLocal` due to `SecureRandom` is thread safe since JDK9.
### Does this PR introduce _any_ user-facing change?
'No'.
### How was this patch tested?
GA tests.
### Was this patch authored or co-authored using generative AI tooling?
'No'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 [spark]
Posted by "mridulm (via GitHub)" <gi...@apache.org>.
mridulm commented on PR #44577:
URL: https://github.com/apache/spark/pull/44577#issuecomment-1876630265
+CC @srowen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #44577:
URL: https://github.com/apache/spark/pull/44577#issuecomment-1876871197
The GA failure is unrelated.
Merged to master. @mridulm @srowen @LuciferYang Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on PR #44577:
URL: https://github.com/apache/spark/pull/44577#issuecomment-1877014627
@dongjoon-hyun Thank you very much!
I use a new computer and the the dev environment seems works bad. I will check my environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44577: [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9
URL: https://github.com/apache/spark/pull/44577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44577:
URL: https://github.com/apache/spark/pull/44577#issuecomment-1877004704
It seems that the previous merging failed.
I merged this to master for Apache Spark 4.0.0. Thank you, @beliefer and all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org