[GitHub] [bookkeeper] dlg99 commented on pull request #3110: PendingReadOp: Fix ledgerEntryImpl reuse problem

[GitBox <gi...@apache.org>]

dlg99 commented on pull request #3110:
URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1069292790


   > it will not memory leak when don't not recycle entry's writeSet. now in this PR we only fix LedgerEntryImpl.close.
   
   @congbobo184 I don't see a reason to not address it right now. It is not a major rework of what you've already done.
   Also, the root cause is not that close() doesn't change state to the complete but that the close() was called on not completed entry. 
   Making sure that the non-completed entry is failed (and thus writeSet is recycled) before calling close() + explicitly checking for that state in the close looks like a right thing to do and won't take long.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org