You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by bjornjon <gi...@git.apache.org> on 2016/03/14 11:31:26 UTC
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
GitHub user bjornjon opened a pull request:
https://github.com/apache/spark/pull/11695
[MINOR][COMMON] Fix copy-paste oversight in variable naming
## What changes were proposed in this pull request?
JavaUtils.java has methods to convert time and byte strings for internal use, this change renames a variable used in byteStringAs(), from timeError to byteError.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bjornjon/spark master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/11695.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #11695
----
commit 13df574bb8fbdcae35780df9ef89c0e781c87887
Author: Bjorn Jonsson <bj...@gmail.com>
Date: 2016-03-14T10:17:48Z
Fix copy-paste oversight in value naming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196262871
I highlighted it just because there have been a few in the past couple days. It's not so much that unrelated tiny changes should be batched together, but that maybe there are other related tiny changes that would be turned up with a search. There may not be, in which case, it's probably OK to merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196488142
**[Test build #2633 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2633/consoleFull)** for PR 11695 at commit [`13df574`](https://github.com/apache/spark/commit/13df574bb8fbdcae35780df9ef89c0e781c87887).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by bjornjon <gi...@git.apache.org>.
Github user bjornjon commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196256049
Sounds good. I'll see what I can spot while reading through the code. Whats the best way to review previous suggested changes like this that were to minor to go in? Maybe some of them are still outstanding and I can batch them together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196419173
**[Test build #2633 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/2633/consoleFull)** for PR 11695 at commit [`13df574`](https://github.com/apache/spark/commit/13df574bb8fbdcae35780df9ef89c0e781c87887).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196245843
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/11695
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196247686
OK, that by itself is probably too minor to bother with. It's not a bad change, but maybe you can look through other similar stretches of code to see if other similar copy / paste errors have been made? it'd be good to try to investigate these in batch as much as possible
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by bjornjon <gi...@git.apache.org>.
Github user bjornjon commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196373173
Read through all the code in common. No similar oversights, at least not with variable naming.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [MINOR][COMMON] Fix copy-paste oversight in va...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/11695#issuecomment-196486176
This passed compilation. Merging into master 1.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org