[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on issue #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it

[GitBox <gi...@apache.org>]

wilfred-s commented on issue #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#issuecomment-597547339
 
 
   Beside the pull in of the core code described above I was overlooking the fact that the admission controller is a separate binary which is build out of just two source files: webhook.go and the mutating_controller.go. This further complicates the design..
   The admission controller is a separate binary and must thus use GPRC to communicate with the shim/scheduler. There is no provision for that in the current setup. The webhook would thus become a pretty heavy executable with a lot of exposure.
   
   Second point: looking at the source admission controller you will see that there is no code outside of some really basic config and logging details that are getting pulled in. You thus have no `entrypoint` or even a `RMProxy`. Adding all this would thus be a major change.
   
   Adding all that into the admission controller would have a far bigger impact than I first thought:
   1. bloat of the code
   2. open up extra ports and adding services to integrate.
   
   I think we need to look in the directions of using REST and directly talk to the core web app. There is already a HTTP server in the webhook so we can leverage that dependency and it keeps it simple. The config is also already loaded by the webhook as it needs the scheduler name.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org