You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/03/12 06:44:16 UTC

[kudu-CR] WIP [util] introduce ThreadPoolToken::Close()

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22614


Change subject: WIP [util] introduce ThreadPoolToken::Close()
......................................................................

WIP [util] introduce ThreadPoolToken::Close()

WIP:
  * add more tests
  * add proper description

Change-Id: Ic226319c191af666233ec735c1787389d051b039
---
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
3 files changed, 250 insertions(+), 24 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/22614/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039
Gerrit-Change-Number: 22614
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [util] introduce ThreadPoolToken::Close()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.

Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22614 )

Change subject: [util] introduce ThreadPoolToken::Close()
......................................................................


Patch Set 6:

Build Started http://jenkins.kudu.apache.org/job/pre_commit/1172/


-- 
To view, visit http://gerrit.cloudera.org:8080/22614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039
Gerrit-Change-Number: 22614
Gerrit-PatchSet: 6
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 13 Mar 2025 23:31:38 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce ThreadPoolToken::Close()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Hello Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22614

to look at the new patch set (#5).

Change subject: [util] introduce ThreadPoolToken::Close()
......................................................................

[util] introduce ThreadPoolToken::Close()

This patch introduces a means to protect a thread pool token from
submission of new tasks, while allowing all of its queued tasks to
complete before the token reaches terminal QUIESCED state.  That's the
main difference from ThreadPoolToken::Shutdown(), where all the token's
queued but not-yet-in-flight tasks are thrown out of the thread pool's
queue.  From this perspective, the newly introduced Close() method might
be considered as a graceful and asynchronous version of its Shutdown()
counterpart.

This patch also adds a few test scenarios to cover the crucial parts
of the newly introduced functionality.

Change-Id: Ic226319c191af666233ec735c1787389d051b039
---
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
3 files changed, 340 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/22614/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039
Gerrit-Change-Number: 22614
Gerrit-PatchSet: 5
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [util] introduce ThreadPoolToken::Close()

Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.

Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22614 )

Change subject: [util] introduce ThreadPoolToken::Close()
......................................................................


Patch Set 7: Verified-1

Build Failed 

http://jenkins.kudu.apache.org/job/pre_commit/1177/ : FAILURE


-- 
To view, visit http://gerrit.cloudera.org:8080/22614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039
Gerrit-Change-Number: 22614
Gerrit-PatchSet: 7
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Mar 2025 23:58:26 +0000
Gerrit-HasComments: No

[kudu-CR] [util] introduce ThreadPoolToken::Close()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22614 )

Change subject: [util] introduce ThreadPoolToken::Close()
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22614/3/src/kudu/util/threadpool.h
File src/kudu/util/threadpool.h:

http://gerrit.cloudera.org:8080/#/c/22614/3/src/kudu/util/threadpool.h@705
PS3, Line 705: GRACEFUL_QUIESCING -> QUIESCED
> GRACEFUL_QUIESCING -> QUIESCING is also a legal transition although will be
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039
Gerrit-Change-Number: 22614
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 13 Mar 2025 02:12:56 +0000
Gerrit-HasComments: Yes

[kudu-CR] [util] introduce ThreadPoolToken::Close()

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.

Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22614 )

Change subject: [util] introduce ThreadPoolToken::Close()
......................................................................

[util] introduce ThreadPoolToken::Close()

This patch introduces a means to protect a thread pool token from
submission of new tasks, while allowing all of its queued tasks to
complete before the token reaches terminal QUIESCED state.  That's the
main difference from ThreadPoolToken::Shutdown(), where all the token's
queued but not-yet-in-flight tasks are thrown out of the thread pool's
queue.  From this perspective, the newly introduced Close() method might
be considered as a graceful and asynchronous version of its Shutdown()
counterpart.

This patch also adds a few test scenarios to cover the crucial parts
of the newly introduced functionality.

Change-Id: Ic226319c191af666233ec735c1787389d051b039
Reviewed-on: http://gerrit.cloudera.org:8080/22614
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/util/threadpool-test.cc
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
3 files changed, 351 insertions(+), 28 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/22614
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039
Gerrit-Change-Number: 22614
Gerrit-PatchSet: 9
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)