[GitHub] [kyuubi] huangzhir commented on pull request #4813: Add the fetchorientation parameter to the /v1/operations/:operationId/log interface

["huangzhir (via GitHub)" <gi...@apache.org>]

huangzhir commented on PR #4813:
URL: https://github.com/apache/kyuubi/pull/4813#issuecomment-1571408642

   
   
   
   > @huangzhir thank you for the work. It seems the performance is poor for `FETCH_PRIOR`, for each request, we will reopen the log file and seek to taget position. Is there a real world use case for it ? If so, we might need to rewrite the code using `RandomAccessFile`. `FETCH_FIRST` looks more useful to me.
   
    I looked at the Hive code (link: https://github.com/apache/hive/blob/a5d7f72dfe51fe8119d209bf61c64b8e94f2f42b/ql/src/java/org/apache/hadoop/hive/ql/session/OperationLog.java#LL156C31-L156C35) and noticed that FETCH_PRIOR is not implemented. Therefore, I have removed FETCH_PRIOR and referenced the Hive OperationLog code to rewrite the code. 
   @ulysses-you Can you please review it?"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org