You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "1996fanrui (via GitHub)" <gi...@apache.org> on 2023/08/05 04:02:11 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #23143: [FLINK-32759][doc] Remove the `cluster.declarative-resource-management.enabled` in doc

1996fanrui opened a new pull request, #23143:
URL: https://github.com/apache/flink/pull/23143

   ## What is the purpose of the change
   
   he cluster.declarative-resource-management.enabled was removed at [FLINK-21095](https://issues.apache.org/jira/browse/FLINK-21095)(https://github.com/apache/flink/pull/15838/files), so it doesn't work now.
   
   However, the flink doc still have it.
   
   ![](https://github.com/apache/flink/assets/38427477/1912dc7a-414f-44e1-906b-762ee1b5432b)
   
   
   ## Brief change log
   
   [FLINK-32759][doc] Remove the `cluster.declarative-resource-management.enabled` in doc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #23143: [FLINK-32759][doc] Remove the `cluster.declarative-resource-management.enabled` in doc

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23143:
URL: https://github.com/apache/flink/pull/23143#issuecomment-1666379967

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "7ee09938a1c348b0d1552fc1ad3a41d598fd2beb",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "7ee09938a1c348b0d1552fc1ad3a41d598fd2beb",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 7ee09938a1c348b0d1552fc1ad3a41d598fd2beb UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #23143: [FLINK-32759][doc] Remove the `cluster.declarative-resource-management.enabled` in doc

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui commented on PR #23143:
URL: https://github.com/apache/flink/pull/23143#issuecomment-1666444157

   Hi @zentol @RocMarshal , would you mind helping take a look this pr in your free time? Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui merged pull request #23143: [FLINK-32759][doc] Remove the `cluster.declarative-resource-management.enabled` in doc

Posted by "1996fanrui (via GitHub)" <gi...@apache.org>.
1996fanrui merged PR #23143:
URL: https://github.com/apache/flink/pull/23143


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] RocMarshal commented on a diff in pull request #23143: [FLINK-32759][doc] Remove the `cluster.declarative-resource-management.enabled` in doc

Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on code in PR #23143:
URL: https://github.com/apache/flink/pull/23143#discussion_r1285302436


##########
docs/content/docs/deployment/elastic_scaling.md:
##########
@@ -135,10 +135,9 @@ One benefit of the Adaptive Scheduler over the default scheduler is that it can
 
 ### Usage
 
-The following configuration parameters need to be set:
+The following configuration parameter need to be set:

Review Comment:
   precise~ 👍 



##########
docs/content/docs/deployment/elastic_scaling.md:
##########
@@ -135,10 +135,9 @@ One benefit of the Adaptive Scheduler over the default scheduler is that it can
 
 ### Usage
 
-The following configuration parameters need to be set:
+The following configuration parameter need to be set:

Review Comment:
   precise~ 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org