You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/06/27 05:19:57 UTC
[GitHub] metamodel pull request #112: Added support for postgresql's "json" and "json...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/112
Added support for postgresql's "json" and "jsonb" data types -> MAP
Hi all,
Here's a PR that adds MetaModel support for PostgreSQL's JSON based data types. I'm currently on a project where we use this data type and unfortunately MetaModel's support for it is very bad (breaks upon insert/update, queries/returns it as a string). I think that it makes most sense to treat the data type as a logical `MAP` type. Hope you agree.
To do this I had to do a refactor of moving static methods from `JdbcUtils` to non-static methods on the `IQueryRewriter` interface. That way those methods can be overridden and apply database-specific behaviour.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel feature/postgresql-json-datatypes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit c420c5b0cabafaea38a139bb1bffd4eb2daa8e52
Author: Kasper S�rensen <i....@gmail.com>
Date: 2016-06-27T05:16:24Z
Added support for postgresql's "json" and "jsonb" data types -> MAP
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #112: Added support for postgresql's "json" and "jsonb" data...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/112
Fixed unittest, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request #112: Added support for postgresql's "json" and "json...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel issue #112: Added support for postgresql's "json" and "jsonb" data...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the issue:
https://github.com/apache/metamodel/pull/112
Merging based on lazy consensus.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---