You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by senorcarbone <gi...@git.apache.org> on 2015/03/23 18:42:01 UTC
[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...
GitHub user senorcarbone opened a pull request:
https://github.com/apache/flink/pull/524
[Flink-1686] Streaming Iterations Slot Sharing Fix
Iteration head instances were using the same identifier for slot sharing which resulted into incorrect execution for streaming iterations. I had to add a unique identifier for each iteration node to fix the issue. They are now working properly judging from the parallel iterations test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink FLINK-1686
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/524.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #524
----
commit a3c80a90ad692bf60e27f72edb15c2f7acd1db17
Author: Paris Carbone <se...@gmail.com>
Date: 2015-03-23T11:23:48Z
[FLINK-1685] [streaming] Use different slot identifier per iteration node subtask
commit e518dd69116dfc2c511d804be6c0d58ef41570b4
Author: Paris Carbone <se...@gmail.com>
Date: 2015-03-23T17:35:14Z
[FLINK-1686] [streaming] add parallel iteration test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...
Posted by senorcarbone <gi...@git.apache.org>.
Github user senorcarbone commented on the pull request:
https://github.com/apache/flink/pull/524#issuecomment-85223415
bad style habits ^^
thanks for reminding me. I also made a minor fix to the test too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...
Posted by gyfora <gi...@git.apache.org>.
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/524#issuecomment-86675840
Looks good to me, lets merge this :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...
Posted by senorcarbone <gi...@git.apache.org>.
Github user senorcarbone closed the pull request at:
https://github.com/apache/flink/pull/524
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [Flink-1686] Streaming Iterations Slot Sharing...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/524#discussion_r26966049
--- Diff: flink-staging/flink-streaming/flink-streaming-core/src/test/java/org/apache/flink/streaming/api/IterateTest.java ---
@@ -87,7 +90,10 @@ public void test() throws Exception {
env.execute();
- assertTrue(iterated);
+ for(boolean iter : iterated)
--- End diff --
we usually have the left curly brace in the same line (I know we don't have any official rule enforcing this ;) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---