You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Jitendra Pandey <ji...@hortonworks.com> on 2014/03/14 10:23:40 UTC
Review Request 19219: Vectorization: Partition column names are not picked
up.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19219/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-6639
https://issues.apache.org/jira/browse/HIVE-6639
Repository: hive-git
Description
-------
Vectorization: Partition column names are not picked up.
Diffs
-----
common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 409a13a
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java 32386fe
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java c26da37
Diff: https://reviews.apache.org/r/19219/diff/
Testing
-------
Thanks,
Jitendra Pandey
Re: Review Request 19219: Vectorization: Partition column names are not
picked up.
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19219/#review37487
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
<https://reviews.apache.org/r/19219/#comment69029>
Why did this change? no new usage that would prompt that as far as I see, and the caller casts needlessly
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
<https://reviews.apache.org/r/19219/#comment69027>
nit: variable is not needed
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
<https://reviews.apache.org/r/19219/#comment69030>
maybe there should be a hashset of names
- Sergey Shelukhin
On March 14, 2014, 9:23 a.m., Jitendra Pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19219/
> -----------------------------------------------------------
>
> (Updated March 14, 2014, 9:23 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-6639
> https://issues.apache.org/jira/browse/HIVE-6639
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> Vectorization: Partition column names are not picked up.
>
>
> Diffs
> -----
>
> common/src/test/org/apache/hadoop/hive/common/type/TestDecimal128.java 409a13a
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastDecimalToTimestamp.java 32386fe
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java c26da37
>
> Diff: https://reviews.apache.org/r/19219/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jitendra Pandey
>
>