You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Thomas Kielbus (Created) (JIRA)" <ji...@apache.org> on 2011/11/02 20:31:33 UTC

[jira] [Created] (THRIFT-1419) AbstractNonBlockingServer does not catch errors when invoking the processor

AbstractNonBlockingServer does not catch errors when invoking the processor
---------------------------------------------------------------------------

                 Key: THRIFT-1419
                 URL: https://issues.apache.org/jira/browse/THRIFT-1419
             Project: Thrift
          Issue Type: Bug
          Components: Java - Library
            Reporter: Thomas Kielbus
            Priority: Minor


Only exceptions are caught when invoking the processor. If an error is thrown, it causes the thread to die silently without setting the frame buffer state. The client can hang forever waiting for a response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1419) AbstractNonBlockingServer does not catch errors when invoking the processor

Posted by "Thomas Kielbus (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Kielbus updated THRIFT-1419:
-----------------------------------

    Patch Info: Patch Available
    
> AbstractNonBlockingServer does not catch errors when invoking the processor
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-1419
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1419
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Thomas Kielbus
>            Priority: Minor
>         Attachments: THRIFT-1419.diff
>
>
> Only exceptions are caught when invoking the processor. If an error is thrown, it causes the thread to die silently without setting the frame buffer state. The client can hang forever waiting for a response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (THRIFT-1419) AbstractNonBlockingServer does not catch errors when invoking the processor

Posted by "Bryan Duxbury (Closed) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-1419.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8
         Assignee: Thomas Kielbus

I just committed this to TRUNK.
                
> AbstractNonBlockingServer does not catch errors when invoking the processor
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-1419
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1419
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Thomas Kielbus
>            Assignee: Thomas Kielbus
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: THRIFT-1419.diff
>
>
> Only exceptions are caught when invoking the processor. If an error is thrown, it causes the thread to die silently without setting the frame buffer state. The client can hang forever waiting for a response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (THRIFT-1419) AbstractNonBlockingServer does not catch errors when invoking the processor

Posted by "Thomas Kielbus (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Thomas Kielbus updated THRIFT-1419:
-----------------------------------

    Attachment: THRIFT-1419.diff
    
> AbstractNonBlockingServer does not catch errors when invoking the processor
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-1419
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1419
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Thomas Kielbus
>            Priority: Minor
>         Attachments: THRIFT-1419.diff
>
>
> Only exceptions are caught when invoking the processor. If an error is thrown, it causes the thread to die silently without setting the frame buffer state. The client can hang forever waiting for a response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (THRIFT-1419) AbstractNonBlockingServer does not catch errors when invoking the processor

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142692#comment-13142692 ] 

Hudson commented on THRIFT-1419:
--------------------------------

Integrated in Thrift #314 (See [https://builds.apache.org/job/Thrift/314/])
    THRIFT-1419. java: AbstractNonBlockingServer does not catch errors when invoking the processor

This patch changes the invoke() method to catch Throwables instead of just Exceptions.

Patch: Thomas Kielbus"

bryanduxbury : http://svn.apache.org/viewvc/?view=rev&rev=1196848
Files : 
* /thrift/trunk/lib/java/src/org/apache/thrift/server/AbstractNonblockingServer.java

                
> AbstractNonBlockingServer does not catch errors when invoking the processor
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-1419
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1419
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Thomas Kielbus
>            Assignee: Thomas Kielbus
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: THRIFT-1419.diff
>
>
> Only exceptions are caught when invoking the processor. If an error is thrown, it causes the thread to die silently without setting the frame buffer state. The client can hang forever waiting for a response.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira