You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/16 23:03:41 UTC
[GitHub] [spark] xinrong-databricks opened a new pull request, #36569: Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`
xinrong-databricks opened a new pull request, #36569:
URL: https://github.com/apache/spark/pull/36569
### What changes were proposed in this pull request?
Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`.
### Why are the changes needed?
Increase pandas API coverage.
### Does this PR introduce _any_ user-facing change?
Yes. `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates` is supported as below.
### How was this patch tested?
Unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36569: [SPARK-39201][PYTHON][PS] Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36569:
URL: https://github.com/apache/spark/pull/36569#issuecomment-1131510364
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a diff in pull request #36569: [SPARK-39201][PYTHON][PS] Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`
Posted by GitBox <gi...@apache.org>.
Yikun commented on code in PR #36569:
URL: https://github.com/apache/spark/pull/36569#discussion_r876716230
##########
python/pyspark/pandas/frame.py:
##########
@@ -12212,7 +12237,8 @@ def explode(self, column: Name) -> "DataFrame":
data_fields[idx] = field.copy(dtype=dtype, spark_type=spark_type, nullable=True)
internal = psdf._internal.with_new_sdf(sdf, data_fields=data_fields)
- return DataFrame(internal)
+ result_df: DataFrame = DataFrame(internal)
Review Comment:
Just curious: any helps of this annotaion? Because I saw many inconsist in current PS codebase.
```python
pdf = DataFrame(internal)
pdf: DataFrame = DataFrame(internal)
```
I thought annotation only helps in public interface/parameter or schema infer, so any other one should be cleanup.
cc @zero323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xinrong-databricks commented on pull request #36569: [SPARK-39201][PYTHON][PS] Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`
Posted by GitBox <gi...@apache.org>.
xinrong-databricks commented on PR #36569:
URL: https://github.com/apache/spark/pull/36569#issuecomment-1130477420
CC @ueshin @HyukjinKwon @itholic @Yikun Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #36569: [SPARK-39201][PYTHON][PS] Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36569: [SPARK-39201][PYTHON][PS] Implement `ignore_index` of `DataFrame.explode` and `DataFrame.drop_duplicates`
URL: https://github.com/apache/spark/pull/36569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org