You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/03/10 11:35:09 UTC
[GitHub] [airflow] potiuk opened a new pull request, #30020: Update documentation for snowflake provider 4.0 breaking change
potiuk opened a new pull request, #30020:
URL: https://github.com/apache/airflow/pull/30020
The 4.0 version of Snowflake was breaking a little more than we described it originally, This PR adds explicit mentioning of the autocommit flag change.
Fixes: #30010
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a diff in pull request #30020: Update documentation for snowflake provider 4.0 breaking change
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on code in PR #30020:
URL: https://github.com/apache/airflow/pull/30020#discussion_r1132629345
##########
airflow/providers/snowflake/operators/snowflake.py:
##########
@@ -42,7 +42,7 @@ class SnowflakeOperator(SQLExecuteQueryOperator):
a list of str (sql statements), or a reference to a template file.
Template references are recognized by str ending in '.sql'
:param autocommit: if True, each command is automatically committed.
- (default value: True)
+ (default value: False)
Review Comment:
I suggest to remove it all together (this is what we usually do)
The default value and the description is taken from the parent class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a diff in pull request #30020: Update documentation for snowflake provider 4.0 breaking change
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #30020:
URL: https://github.com/apache/airflow/pull/30020#discussion_r1132644823
##########
airflow/providers/snowflake/operators/snowflake.py:
##########
@@ -42,7 +42,7 @@ class SnowflakeOperator(SQLExecuteQueryOperator):
a list of str (sql statements), or a reference to a template file.
Template references are recognized by str ending in '.sql'
:param autocommit: if True, each command is automatically committed.
- (default value: True)
+ (default value: False)
Review Comment:
Yep.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30020: Update documentation for snowflake provider 4.0 breaking change
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30020:
URL: https://github.com/apache/airflow/pull/30020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org