You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Rodent of Unusual Size <co...@Apache.Org> on 1998/09/04 01:08:23 UTC

Oddity in mod_speling?

The following fragment in mod_speling.c(1.24) line 460 seems
a bit odd:

>         t = ap_pstrcat(p, t, "<li><a href=\"", url,
>                        variant[i].name, r->path_info, "\">",
>                        variant[i].name, r->path_info,
>                        r->parsed_uri.query ? "?" : "",
>                        r->parsed_uri.query ? r->parsed_uri.query : "",
>                        "</a> (",
>                        sp_reason_str[(int) (variant[i].quality)],
>                        ")\n", NULL);

Why is the link omitting the QUERY_STRING portion of
the URI?  It's displayed on the page, but not passed
when the link is clicked.

#ken    P-)}

Ken Coar                    <http://Web.Golux.Com/coar/>
Apache Group member         <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>

Re: Oddity in mod_speling?

Posted by Rodent of Unusual Size <co...@Apache.Org>.
Martin Kraemer wrote:
> 
> Oops! It's an oversight. I *thought* I had fixed it (but noticed only
> today that the redirections still omitted the query arg).
> I'll fix it ASAP.

I'm going to be doing some work in this piece of the code.  I'll
wait for your commit before I proceed.

#ken    P-)}

Ken Coar                    <http://Web.Golux.Com/coar/>
Apache Group member         <http://www.apache.org/>
"Apache Server for Dummies" <http://Web.Golux.Com/coar/ASFD/>

Re: Oddity in mod_speling?

Posted by Martin Kraemer <ma...@mch.sni.de>.
On Thu, Sep 03, 1998 at 07:08:23PM -0400, Rodent of Unusual Size wrote:
> The following fragment in mod_speling.c(1.24) line 460 seems
> a bit odd:
> 
> >         t = ap_pstrcat(p, t, "<li><a href=\"", url,
> >                        variant[i].name, r->path_info, "\">",
> >                        variant[i].name, r->path_info,
> >                        r->parsed_uri.query ? "?" : "",
> >                        r->parsed_uri.query ? r->parsed_uri.query : "",
> >                        "</a> (",
> >                        sp_reason_str[(int) (variant[i].quality)],
> >                        ")\n", NULL);
> 
> Why is the link omitting the QUERY_STRING portion of
> the URI?  It's displayed on the page, but not passed
> when the link is clicked.

Oops! It's an oversight. I *thought* I had fixed it (but noticed only
today that the redirections still omitted the query arg).
I'll fix it ASAP.

Thanks for pointing that out.

    Martin
--
| S I E M E N S |  <Ma...@mch.sni.de>  |      Siemens Nixdorf
| ------------- |   Voice: +49-89-636-46021     |  Informationssysteme AG
| N I X D O R F |   FAX:   +49-89-636-44994     |   81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request