You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/01/16 19:27:09 UTC
[kudu-CR] heavy-update-compaction-itest
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9037
to review the following change.
Change subject: heavy-update-compaction-itest
......................................................................
heavy-update-compaction-itest
This is an integration test which simulates an extremely update-heavy
workload. It was written while trying to repro KUDU-2251, and
subsequently led to discovering the issues in KUDU-2253.
Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/heavy-update-compaction-itest.cc
2 files changed, 239 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9037/1
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] heavy-update-compaction-itest
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 )
Change subject: heavy-update-compaction-itest
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc
File src/kudu/integration-tests/heavy-update-compaction-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@92
PS1, Line 92: b.AddColumn("val_a")->Type(KuduColumnSchema::STRING)->NotNull();
> Maybe parameterize (or at least store in a class constant) the number of st
Done
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@168
PS1, Line 168: 100 rows.
> nit: might not be 100, right?
Done
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@217
PS1, Line 217: scanner.SetTimeoutMillis(120 * 1000);
> make this a flag so that we can change this if we change "rows" or "rounds"
Done
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@225
PS1, Line 225: const auto &
> Nit: const auto&
Done
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@230
PS1, Line 230: EXPECT_EQ(actual_val, final_values[final_values_offset++]);
> Nit: just curious why you used EXPECT here and not ASSERT, given that the o
I don't consider this to be a fatal failure, since the test can keep going if it fails without causing a logic or memory-safety error. The upside is that if this case were to fail it may be easier to debug if you get the full set of errors instead of short circuiting.
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 16 Jan 2018 20:14:38 +0000
Gerrit-HasComments: Yes
[kudu-CR] heavy-update-compaction-itest
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 )
Change subject: heavy-update-compaction-itest
......................................................................
Patch Set 1:
Note for reviewers: this test was included in revision 6 of https://gerrit.cloudera.org/#/c/8951/.
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:33:32 +0000
Gerrit-HasComments: No
[kudu-CR] heavy-update-compaction-itest
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 )
Change subject: heavy-update-compaction-itest
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 16 Jan 2018 20:45:16 +0000
Gerrit-HasComments: No
[kudu-CR] heavy-update-compaction-itest
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9037 )
Change subject: heavy-update-compaction-itest
......................................................................
heavy-update-compaction-itest
This is an integration test which simulates an extremely update-heavy
workload. It was written while trying to repro KUDU-2251, and
subsequently led to discovering the issues in KUDU-2253.
Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Reviewed-on: http://gerrit.cloudera.org:8080/9037
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/heavy-update-compaction-itest.cc
2 files changed, 245 insertions(+), 0 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] heavy-update-compaction-itest
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, Adar Dembo, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9037
to look at the new patch set (#2).
Change subject: heavy-update-compaction-itest
......................................................................
heavy-update-compaction-itest
This is an integration test which simulates an extremely update-heavy
workload. It was written while trying to repro KUDU-2251, and
subsequently led to discovering the issues in KUDU-2253.
Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/heavy-update-compaction-itest.cc
2 files changed, 245 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/9037/2
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] heavy-update-compaction-itest
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 )
Change subject: heavy-update-compaction-itest
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc
File src/kudu/integration-tests/heavy-update-compaction-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@168
PS1, Line 168: 100 rows.
nit: might not be 100, right?
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@217
PS1, Line 217: scanner.SetTimeoutMillis(120 * 1000);
make this a flag so that we can change this if we change "rows" or "rounds"
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:50:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] heavy-update-compaction-itest
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9037 )
Change subject: heavy-update-compaction-itest
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc
File src/kudu/integration-tests/heavy-update-compaction-itest.cc:
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@92
PS1, Line 92: b.AddColumn("val_a")->Type(KuduColumnSchema::STRING)->NotNull();
Maybe parameterize (or at least store in a class constant) the number of string rows? Would also help avoid the "i <= 5" magic numbers below.
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@225
PS1, Line 225: const auto &
Nit: const auto&
http://gerrit.cloudera.org:8080/#/c/9037/1/src/kudu/integration-tests/heavy-update-compaction-itest.cc@230
PS1, Line 230: EXPECT_EQ(actual_val, final_values[final_values_offset++]);
Nit: just curious why you used EXPECT here and not ASSERT, given that the other checks in this test are all ASSERT?
--
To view, visit http://gerrit.cloudera.org:8080/9037
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie2e30c63e1fedafe1eeb672346700ee8c5e2bb2c
Gerrit-Change-Number: 9037
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 16 Jan 2018 19:34:37 +0000
Gerrit-HasComments: Yes