You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bloodhound.apache.org by Ryan Ollos <ry...@wandisco.com> on 2014/02/11 19:14:24 UTC
Possible unresolved reference in trac.resource
In `trac.resource:ResourceSystem`, there is a method
`get_known_neighborhoods`. It doesn't appear to be used anywhere so it is
probably not causing any trouble, but there is an unresolved reference
"manager":
def get_known_neighborhoods(self):
"""Return a list of all the realm names of neighborhoods."""
realms = []
for connector in self.resource_connectors:
for realm in manager.get_supported_neighborhoods() or []:
realms.append(realm)
return realms
It seems like we should either fix it or remove the code, in case someone
tries to utilize the method.
Olemis, can you direct us to a proper fix?
- Ryan
Re: Possible unresolved reference in trac.resource
Posted by Ryan Ollos <ry...@wandisco.com>.
On Tue, Feb 11, 2014 at 12:22 PM, Olemis Lang <ol...@gmail.com> wrote:
> On Tue, Feb 11, 2014 at 2:38 PM, Olemis Lang <ol...@gmail.com> wrote:
>
> >
> > On Tue, Feb 11, 2014 at 1:14 PM, Ryan Ollos <ryan.ollos@wandisco.com
> >wrote:
> >
> >> In `trac.resource:ResourceSystem`, there is a method
> >> `get_known_neighborhoods`. It doesn't appear to be used anywhere so it
> is
> >> probably not causing any trouble, but there is an unresolved reference
> >> "manager":
> >>
> >> def get_known_neighborhoods(self):
> >> """Return a list of all the realm names of neighborhoods."""
> >> realms = []
> >> for connector in self.resource_connectors:
> >> for realm in manager.get_supported_neighborhoods() or []:
> >> realms.append(realm)
> >> return realms
> >>
> >> It seems like we should either fix it or remove the code, in case
> someone
> >> tries to utilize the method.
> >>
> >> Olemis, can you direct us to a proper fix?
> >>
> >>
> > Oh yes ! In a minute , I did not notice that . I'll propose a patch with
> > test cases
> > ;)
> >
> >
> >
> please review the patch attached to #754
>
>
Thanks for the quick fix! I'll commit the change today.
Re: Possible unresolved reference in trac.resource
Posted by Olemis Lang <ol...@gmail.com>.
On Tue, Feb 11, 2014 at 2:38 PM, Olemis Lang <ol...@gmail.com> wrote:
>
> On Tue, Feb 11, 2014 at 1:14 PM, Ryan Ollos <ry...@wandisco.com>wrote:
>
>> In `trac.resource:ResourceSystem`, there is a method
>> `get_known_neighborhoods`. It doesn't appear to be used anywhere so it is
>> probably not causing any trouble, but there is an unresolved reference
>> "manager":
>>
>> def get_known_neighborhoods(self):
>> """Return a list of all the realm names of neighborhoods."""
>> realms = []
>> for connector in self.resource_connectors:
>> for realm in manager.get_supported_neighborhoods() or []:
>> realms.append(realm)
>> return realms
>>
>> It seems like we should either fix it or remove the code, in case someone
>> tries to utilize the method.
>>
>> Olemis, can you direct us to a proper fix?
>>
>>
> Oh yes ! In a minute , I did not notice that . I'll propose a patch with
> test cases
> ;)
>
>
>
please review the patch attached to #754
--
Regards,
Olemis - @olemislc
Re: Possible unresolved reference in trac.resource
Posted by Olemis Lang <ol...@gmail.com>.
On Tue, Feb 11, 2014 at 1:14 PM, Ryan Ollos <ry...@wandisco.com> wrote:
> In `trac.resource:ResourceSystem`, there is a method
> `get_known_neighborhoods`. It doesn't appear to be used anywhere so it is
> probably not causing any trouble, but there is an unresolved reference
> "manager":
>
> def get_known_neighborhoods(self):
> """Return a list of all the realm names of neighborhoods."""
> realms = []
> for connector in self.resource_connectors:
> for realm in manager.get_supported_neighborhoods() or []:
> realms.append(realm)
> return realms
>
> It seems like we should either fix it or remove the code, in case someone
> tries to utilize the method.
>
> Olemis, can you direct us to a proper fix?
>
>
Oh yes ! In a minute , I did not notice that . I'll propose a patch with
test cases
;)
--
Regards,
Olemis - @olemislc