You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2023/12/06 19:32:28 UTC
[PR] HDDS-9853. Bump JUnit5 to 5.10.1 [ozone]
adoroszlai opened a new pull request, #5741:
URL: https://github.com/apache/ozone/pull/5741
## What changes were proposed in this pull request?
Bump JUnit5 and related dependencies to current latest version.
Switch to `junit-bom` to ensure consistent versions for all JUnit5 artifacts.
https://issues.apache.org/jira/browse/HDDS-9853
## How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/7118343498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9853. Bump JUnit5 to 5.10.1 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on code in PR #5741:
URL: https://github.com/apache/ozone/pull/5741#discussion_r1422981872
##########
pom.xml:
##########
@@ -225,8 +225,8 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<powermock2.version>2.0.4</powermock2.version>
<jmockit.version>1.24</jmockit.version>
<junit4.version>4.13.1</junit4.version>
- <junit.jupiter.version>5.8.2</junit.jupiter.version>
- <junit.platform.version>1.8.2</junit.platform.version>
+ <junit.jupiter.version>5.10.1</junit.jupiter.version>
+ <junit.platform.version>1.10.1</junit.platform.version>
Review Comment:
Thanks @hemantk-12 for the review, both are good points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9853. Bump JUnit5 to 5.10.1 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #5741:
URL: https://github.com/apache/ozone/pull/5741
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9853. Bump JUnit5 to 5.10.1 [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on code in PR #5741:
URL: https://github.com/apache/ozone/pull/5741#discussion_r1422888012
##########
pom.xml:
##########
@@ -225,8 +225,8 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<powermock2.version>2.0.4</powermock2.version>
<jmockit.version>1.24</jmockit.version>
<junit4.version>4.13.1</junit4.version>
- <junit.jupiter.version>5.8.2</junit.jupiter.version>
- <junit.platform.version>1.8.2</junit.platform.version>
+ <junit.jupiter.version>5.10.1</junit.jupiter.version>
Review Comment:
nit: should we just call it `junit5.version`?
##########
pom.xml:
##########
@@ -225,8 +225,8 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<powermock2.version>2.0.4</powermock2.version>
<jmockit.version>1.24</jmockit.version>
<junit4.version>4.13.1</junit4.version>
- <junit.jupiter.version>5.8.2</junit.jupiter.version>
- <junit.platform.version>1.8.2</junit.platform.version>
+ <junit.jupiter.version>5.10.1</junit.jupiter.version>
+ <junit.platform.version>1.10.1</junit.platform.version>
Review Comment:
If I'm not wrong, it is not needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9853. Bump JUnit5 to 5.10.1 [ozone]
Posted by "hemantk-12 (via GitHub)" <gi...@apache.org>.
hemantk-12 commented on code in PR #5741:
URL: https://github.com/apache/ozone/pull/5741#discussion_r1422886678
##########
pom.xml:
##########
@@ -225,8 +225,8 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs
<powermock2.version>2.0.4</powermock2.version>
<jmockit.version>1.24</jmockit.version>
<junit4.version>4.13.1</junit4.version>
- <junit.jupiter.version>5.8.2</junit.jupiter.version>
- <junit.platform.version>1.8.2</junit.platform.version>
+ <junit.jupiter.version>5.10.1</junit.jupiter.version>
+ <junit.platform.version>1.10.1</junit.platform.version>
Review Comment:
If I'm not wrong, `platform.version` is not needed anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-9853. Bump JUnit5 to 5.10.1 [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #5741:
URL: https://github.com/apache/ozone/pull/5741#issuecomment-1850892865
Thanks @hemantk-12 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org