You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/07 07:45:32 UTC
[GitHub] [spark] viirya opened a new pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
viirya opened a new pull request #33924:
URL: https://github.com/apache/spark/pull/33924
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This patch proposes to add e2e tests for using Hadoop codecs to write sequence files.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To improve test coverage.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914861488
late LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33924:
URL: https://github.com/apache/spark/pull/33924#discussion_r703264724
##########
File path: core/src/test/scala/org/apache/spark/FileSuite.scala
##########
@@ -113,25 +113,33 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
assert(output.map(_.toString).collect().toList === List("(1,a)", "(2,aa)", "(3,aaa)"))
}
- test("SequenceFile (compressed)") {
- sc = new SparkContext("local", "test")
- val normalDir = new File(tempDir, "output_normal").getAbsolutePath
- val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val codec = new DefaultCodec()
+ def runSequenceFileCodecTest(codec: CompressionCodec, codecName: String): Unit = {
+ test(s"SequenceFile (compressed) - $codecName") {
+ sc = new SparkContext("local", "test")
+ val normalDir = new File(tempDir, "output_normal").getAbsolutePath
+ val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
- data.saveAsSequenceFile(normalDir)
- data.saveAsSequenceFile(compressedOutputDir, Some(classOf[DefaultCodec]))
+ val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
+ data.saveAsSequenceFile(normalDir)
+ data.saveAsSequenceFile(compressedOutputDir, Some(codec.getClass))
- val normalFile = new File(normalDir, "part-00000")
- val normalContent = sc.sequenceFile[String, String](normalDir).collect
- assert(normalContent === Array.fill(100)(("abc", "abc")))
+ val normalFile = new File(normalDir, "part-00000")
+ val normalContent = sc.sequenceFile[String, String](normalDir).collect
+ assert(normalContent === Array.fill(100)(("abc", "abc")))
- val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
- val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
- assert(compressedContent === Array.fill(100)(("abc", "abc")))
+ val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
+ val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
+ assert(compressedContent === Array.fill(100)(("abc", "abc")))
- assert(compressedFile.length < normalFile.length)
+ assert(compressedFile.length < normalFile.length)
+ }
+ }
+
+ // Hadoop "gzip" codec doesn't support sequence file yet.
+ // Hadoop "zstd" codecs needs native library installed.
+ Seq((new DefaultCodec(), "default"), (new BZip2Codec(), "bzip2"), (new GzipCodec(), "gzip"),
+ (new Lz4Codec(), "lz4"), (new SnappyCodec, "snappy")).foreach { case (codec, codecName) =>
Review comment:
lz4 codecs currently fails due to SPARK-36669.
snappy codec currently fails due to SPARK-36681.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914146153
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914525602
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #33924:
URL: https://github.com/apache/spark/pull/33924#discussion_r703277386
##########
File path: core/src/test/scala/org/apache/spark/FileSuite.scala
##########
@@ -113,25 +113,33 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
assert(output.map(_.toString).collect().toList === List("(1,a)", "(2,aa)", "(3,aaa)"))
}
- test("SequenceFile (compressed)") {
- sc = new SparkContext("local", "test")
- val normalDir = new File(tempDir, "output_normal").getAbsolutePath
- val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val codec = new DefaultCodec()
+ def runSequenceFileCodecTest(codec: CompressionCodec, codecName: String): Unit = {
+ test(s"SequenceFile (compressed) - $codecName") {
+ sc = new SparkContext("local", "test")
+ val normalDir = new File(tempDir, "output_normal").getAbsolutePath
+ val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
- data.saveAsSequenceFile(normalDir)
- data.saveAsSequenceFile(compressedOutputDir, Some(classOf[DefaultCodec]))
+ val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
+ data.saveAsSequenceFile(normalDir)
+ data.saveAsSequenceFile(compressedOutputDir, Some(codec.getClass))
- val normalFile = new File(normalDir, "part-00000")
- val normalContent = sc.sequenceFile[String, String](normalDir).collect
- assert(normalContent === Array.fill(100)(("abc", "abc")))
+ val normalFile = new File(normalDir, "part-00000")
+ val normalContent = sc.sequenceFile[String, String](normalDir).collect
+ assert(normalContent === Array.fill(100)(("abc", "abc")))
- val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
- val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
- assert(compressedContent === Array.fill(100)(("abc", "abc")))
+ val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
+ val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
+ assert(compressedContent === Array.fill(100)(("abc", "abc")))
- assert(compressedFile.length < normalFile.length)
+ assert(compressedFile.length < normalFile.length)
+ }
+ }
+
+ // Hadoop "gzip" codec doesn't support sequence file yet.
+ // Hadoop "zstd" codecs needs native library installed.
+ Seq((new DefaultCodec(), "default"), (new BZip2Codec(), "bzip2"), (new GzipCodec(), "gzip"),
+ (new Lz4Codec(), "lz4"), (new SnappyCodec, "snappy")).foreach { case (codec, codecName) =>
Review comment:
Thank you for filing JIRAs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914519896
cc @sunchao @cloud-fan @dbtsai too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914158443
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143040/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914489685
**[Test build #143054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143054/testReport)** for PR 33924 at commit [`a9139b3`](https://github.com/apache/spark/commit/a9139b34637e0c6b1eec8eb3be55569500a0fbfa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914158443
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143040/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #33924:
URL: https://github.com/apache/spark/pull/33924#discussion_r703793605
##########
File path: core/src/test/scala/org/apache/spark/FileSuite.scala
##########
@@ -113,25 +113,34 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
assert(output.map(_.toString).collect().toList === List("(1,a)", "(2,aa)", "(3,aaa)"))
}
- test("SequenceFile (compressed)") {
- sc = new SparkContext("local", "test")
- val normalDir = new File(tempDir, "output_normal").getAbsolutePath
- val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val codec = new DefaultCodec()
+ def runSequenceFileCodecTest(codec: CompressionCodec, codecName: String): Unit = {
+ test(s"SequenceFile (compressed) - $codecName") {
+ sc = new SparkContext("local", "test")
+ val normalDir = new File(tempDir, "output_normal").getAbsolutePath
+ val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
- data.saveAsSequenceFile(normalDir)
- data.saveAsSequenceFile(compressedOutputDir, Some(classOf[DefaultCodec]))
+ val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
+ data.saveAsSequenceFile(normalDir)
+ data.saveAsSequenceFile(compressedOutputDir, Some(codec.getClass))
- val normalFile = new File(normalDir, "part-00000")
- val normalContent = sc.sequenceFile[String, String](normalDir).collect
- assert(normalContent === Array.fill(100)(("abc", "abc")))
+ val normalFile = new File(normalDir, "part-00000")
+ val normalContent = sc.sequenceFile[String, String](normalDir).collect
+ assert(normalContent === Array.fill(100)(("abc", "abc")))
- val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
- val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
- assert(compressedContent === Array.fill(100)(("abc", "abc")))
+ val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
+ val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
+ assert(compressedContent === Array.fill(100)(("abc", "abc")))
- assert(compressedFile.length < normalFile.length)
+ assert(compressedFile.length < normalFile.length)
+ }
+ }
+
+ // Hadoop "gzip" codec doesn't support sequence file yet.
Review comment:
`Hadoop "gzip" codec requires native library installed for gzip compressed seq file.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya closed pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
viirya closed pull request #33924:
URL: https://github.com/apache/spark/pull/33924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914607872
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143054/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914523478
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914606911
+1, late LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914103116
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914146234
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914488257
We have dedicated JIRAs for snappy and lz4 issues. We already verified the issues in above CI test, going to remove them first to make test passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914157379
**[Test build #143040 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143040/testReport)** for PR 33924 at commit [`a0b115f`](https://github.com/apache/spark/commit/a0b115f1d56d7ac9a53986f25cdf40a7ae728a6d).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914607872
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143054/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
viirya commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914597878
The last commit is comment doc only. Thanks for reviewing. Merging to master/3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914072297
**[Test build #143040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143040/testReport)** for PR 33924 at commit [`a0b115f`](https://github.com/apache/spark/commit/a0b115f1d56d7ac9a53986f25cdf40a7ae728a6d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914518137
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914583873
**[Test build #143054 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143054/testReport)** for PR 33924 at commit [`a9139b3`](https://github.com/apache/spark/commit/a9139b34637e0c6b1eec8eb3be55569500a0fbfa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914146234
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47543/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #33924:
URL: https://github.com/apache/spark/pull/33924#discussion_r703802047
##########
File path: core/src/test/scala/org/apache/spark/FileSuite.scala
##########
@@ -113,25 +113,34 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
assert(output.map(_.toString).collect().toList === List("(1,a)", "(2,aa)", "(3,aaa)"))
}
- test("SequenceFile (compressed)") {
- sc = new SparkContext("local", "test")
- val normalDir = new File(tempDir, "output_normal").getAbsolutePath
- val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val codec = new DefaultCodec()
+ def runSequenceFileCodecTest(codec: CompressionCodec, codecName: String): Unit = {
+ test(s"SequenceFile (compressed) - $codecName") {
+ sc = new SparkContext("local", "test")
+ val normalDir = new File(tempDir, "output_normal").getAbsolutePath
+ val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
- data.saveAsSequenceFile(normalDir)
- data.saveAsSequenceFile(compressedOutputDir, Some(classOf[DefaultCodec]))
+ val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
+ data.saveAsSequenceFile(normalDir)
+ data.saveAsSequenceFile(compressedOutputDir, Some(codec.getClass))
- val normalFile = new File(normalDir, "part-00000")
- val normalContent = sc.sequenceFile[String, String](normalDir).collect
- assert(normalContent === Array.fill(100)(("abc", "abc")))
+ val normalFile = new File(normalDir, "part-00000")
+ val normalContent = sc.sequenceFile[String, String](normalDir).collect
+ assert(normalContent === Array.fill(100)(("abc", "abc")))
- val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
- val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
- assert(compressedContent === Array.fill(100)(("abc", "abc")))
+ val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
+ val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
+ assert(compressedContent === Array.fill(100)(("abc", "abc")))
- assert(compressedFile.length < normalFile.length)
+ assert(compressedFile.length < normalFile.length)
+ }
+ }
+
+ // Hadoop "gzip" codec doesn't support sequence file yet.
+ // Hadoop "zstd" codec needs native library installed.
Review comment:
Thanks. Revised as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914072297
**[Test build #143040 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143040/testReport)** for PR 33924 at commit [`a0b115f`](https://github.com/apache/spark/commit/a0b115f1d56d7ac9a53986f25cdf40a7ae728a6d).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914525602
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47557/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dbtsai commented on a change in pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
dbtsai commented on a change in pull request #33924:
URL: https://github.com/apache/spark/pull/33924#discussion_r703794452
##########
File path: core/src/test/scala/org/apache/spark/FileSuite.scala
##########
@@ -113,25 +113,34 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {
assert(output.map(_.toString).collect().toList === List("(1,a)", "(2,aa)", "(3,aaa)"))
}
- test("SequenceFile (compressed)") {
- sc = new SparkContext("local", "test")
- val normalDir = new File(tempDir, "output_normal").getAbsolutePath
- val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val codec = new DefaultCodec()
+ def runSequenceFileCodecTest(codec: CompressionCodec, codecName: String): Unit = {
+ test(s"SequenceFile (compressed) - $codecName") {
+ sc = new SparkContext("local", "test")
+ val normalDir = new File(tempDir, "output_normal").getAbsolutePath
+ val compressedOutputDir = new File(tempDir, "output_compressed").getAbsolutePath
- val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
- data.saveAsSequenceFile(normalDir)
- data.saveAsSequenceFile(compressedOutputDir, Some(classOf[DefaultCodec]))
+ val data = sc.parallelize(Seq.fill(100)("abc"), 1).map(x => (x, x))
+ data.saveAsSequenceFile(normalDir)
+ data.saveAsSequenceFile(compressedOutputDir, Some(codec.getClass))
- val normalFile = new File(normalDir, "part-00000")
- val normalContent = sc.sequenceFile[String, String](normalDir).collect
- assert(normalContent === Array.fill(100)(("abc", "abc")))
+ val normalFile = new File(normalDir, "part-00000")
+ val normalContent = sc.sequenceFile[String, String](normalDir).collect
+ assert(normalContent === Array.fill(100)(("abc", "abc")))
- val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
- val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
- assert(compressedContent === Array.fill(100)(("abc", "abc")))
+ val compressedFile = new File(compressedOutputDir, "part-00000" + codec.getDefaultExtension)
+ val compressedContent = sc.sequenceFile[String, String](compressedOutputDir).collect
+ assert(compressedContent === Array.fill(100)(("abc", "abc")))
- assert(compressedFile.length < normalFile.length)
+ assert(compressedFile.length < normalFile.length)
+ }
+ }
+
+ // Hadoop "gzip" codec doesn't support sequence file yet.
+ // Hadoop "zstd" codec needs native library installed.
Review comment:
zstd is the same as gzip before your gzip codec is released in hadoop. Maybe just say
`Hadoop "gzip" and "zstd" codecs requires native library installed for sequence files`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914768778
LGTM2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #33924: [SPARK-36682][CORE][TEST] Add Hadoop sequence file test for different Hadoop codecs
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33924:
URL: https://github.com/apache/spark/pull/33924#issuecomment-914489685
**[Test build #143054 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143054/testReport)** for PR 33924 at commit [`a9139b3`](https://github.com/apache/spark/commit/a9139b34637e0c6b1eec8eb3be55569500a0fbfa).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org