[GitHub] [flink] haishui126 commented on a diff in pull request #22291: [FLINK-31632] maxAllowedWatermark overflow

["haishui126 (via GitHub)" <gi...@apache.org>]

haishui126 commented on code in PR #22291:
URL: https://github.com/apache/flink/pull/22291#discussion_r1159239249


##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/SourceOperatorAlignmentTest.java:
##########
@@ -167,6 +167,9 @@ public void testWatermarkAlignmentWithIdleness() throws Exception {
             assertThat(operator.emitNext(actualOutput), is(DataInputStatus.NOTHING_AVAILABLE));
             context.getTimeService().advance(1);
             assertLatestReportedWatermarkEvent(context, Long.MAX_VALUE);
+            // receive Long.MAX_VALUE as WatermarkAlignmentEvent

Review Comment:
   Yes! I have read the code just now, I find the `currentMaxDesiredWatermark` is maxWatermark by default, that's why the old test passed. I'm confused whether it's right to write like this now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org