You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/06/24 13:40:04 UTC
[GitHub] [shardingsphere] Liangda-w opened a new pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Liangda-w opened a new pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000
Relates #10513 .
Changes proposed in this pull request:
- Add Oracle SQL - [ASSOCIATE STATISTICS](https://docs.oracle.com/en/database/oracle/oracle-database/19/sqlrf/ASSOCIATE-STATISTICS.html#GUID-BD02BA6A-32A7-4093-A6B6-BAE860C0F834)
- Add corresponding test cases
@wgy8283335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-868510093
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#11000](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a7d4af9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/be8c22124ba1db66dd18fef963c84682fa855b34?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (be8c221) will **increase** coverage by `0.07%`.
> The diff coverage is `73.68%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #11000 +/- ##
============================================
+ Coverage 65.19% 65.27% +0.07%
Complexity 701 701
============================================
Files 1809 1811 +2
Lines 30787 30806 +19
Branches 5556 5561 +5
============================================
+ Hits 20072 20108 +36
+ Misses 9124 9106 -18
- Partials 1591 1592 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ser/sql/common/segment/ddl/index/IndexSegment.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvY29tbW9uL3NlZ21lbnQvZGRsL2luZGV4L0luZGV4U2VnbWVudC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...oracle/ddl/OracleAssociateStatisticsStatement.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLXN0YXRlbWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWwvZGlhbGVjdC9zdGF0ZW1lbnQvb3JhY2xlL2RkbC9PcmFjbGVBc3NvY2lhdGVTdGF0aXN0aWNzU3RhdGVtZW50LmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...r/statement/impl/OracleDDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1vcmFjbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NxbC9wYXJzZXIvb3JhY2xlL3Zpc2l0b3Ivc3RhdGVtZW50L2ltcGwvT3JhY2xlRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `83.81% <100.00%> (+1.31%)` | :arrow_up: |
| [...l/parser/core/database/visitor/SQLVisitorRule.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWVuZ2luZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9jb3JlL2RhdGFiYXNlL3Zpc2l0b3IvU1FMVmlzaXRvclJ1bGUuamF2YQ==) | `100.00% <100.00%> (ø)` | |
| [...ing/core/job/task/incremental/IncrementalTask.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbmNyZW1lbnRhbC9JbmNyZW1lbnRhbFRhc2suamF2YQ==) | `75.00% <0.00%> (+2.08%)` | :arrow_up: |
| [...scaling/core/job/task/inventory/InventoryTask.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvdGFzay9pbnZlbnRvcnkvSW52ZW50b3J5VGFzay5qYXZh) | `75.55% <0.00%> (+6.66%)` | :arrow_up: |
| [...re/scaling/core/executor/engine/ExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9lbmdpbmUvRXhlY3V0ZUVuZ2luZS5qYXZh) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
| [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/11000/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `51.85% <0.00%> (+29.62%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [be8c221...a7d4af9](https://codecov.io/gh/apache/shardingsphere/pull/11000?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-871068208
@Liangda-w Sure.
Plus, the 5.0.0-beta-release has online already. What you did and your name exactly were included in [Release-news](https://mp.weixin.qq.com/s/hqFHEAPZHcoEfC4ghj3QSA). Good job. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-870495124
Hi @tristaZero , is it the time to merge this PR?:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#discussion_r658500567
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -1813,3 +1809,36 @@ validationClauses
intoClause
: INTO tableName
;
+
+associateStatistics
+ : ASSOCIATE STATISTICS WITH (columnAssociation | functionAssociation) storageTableClause?
+ ;
+
+columnAssociation
+ : COLUMNS tableName DOT_ columnName (COMMA_ tableName DOT_ columnName)* usingStatisticsType
Review comment:
Where is schemaName?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-871068208
@Liangda-w Sure.
Plus, the 5.0.0-beta-release has online already. What you did exactly was included in [Release-news](https://mp.weixin.qq.com/s/hqFHEAPZHcoEfC4ghj3QSA). Good job. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-870495124
Hi @tristaZero , is it the time to merge this PR?:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on a change in pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#discussion_r658720054
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-oracle/src/main/antlr4/imports/oracle/DDLStatement.g4
##########
@@ -1813,3 +1809,36 @@ validationClauses
intoClause
: INTO tableName
;
+
+associateStatistics
+ : ASSOCIATE STATISTICS WITH (columnAssociation | functionAssociation) storageTableClause?
+ ;
+
+columnAssociation
+ : COLUMNS tableName DOT_ columnName (COMMA_ tableName DOT_ columnName)* usingStatisticsType
Review comment:
`tableName` is defined as
```
tableName
: (owner DOT_)? name
;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-868234874
I‘d like to review this merge request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#discussion_r658503694
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/segment/impl/index/ExpectedIndex.java
##########
@@ -20,11 +20,17 @@
import lombok.Getter;
import lombok.Setter;
import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.AbstractExpectedIdentifierSQLSegment;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.table.ExpectedOwner;
Review comment:
Why modify this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wgy8283335 commented on a change in pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
wgy8283335 commented on a change in pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#discussion_r658503869
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/segment/index/IndexAssert.java
##########
@@ -34,7 +37,7 @@
public final class IndexAssert {
/**
- * Assert actual column segment is correct with expected column.
+ * Assert actual index segment is correct with expected index.
Review comment:
Why modify this class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero commented on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
tristaZero commented on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-871068208
@Liangda-w Sure, sorry for my late response.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-871068208
@Liangda-w Sure.
Plus, the 5.0.0-beta-release has online already. What you did and your name exactly were presented in [Release-news](https://mp.weixin.qq.com/s/hqFHEAPZHcoEfC4ghj3QSA). Good job. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on a change in pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#discussion_r658722968
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/segment/index/IndexAssert.java
##########
@@ -34,7 +37,7 @@
public final class IndexAssert {
/**
- * Assert actual column segment is correct with expected column.
+ * Assert actual index segment is correct with expected index.
Review comment:
Index can also have schema/owner (from my understanding, these two are identical), so add owner in IndexAssert.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
tristaZero merged pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero edited a comment on pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#issuecomment-871068208
@Liangda-w Sure.
Plus, the 5.0.0-beta-release has online already. What you did and your name exactly was included in [Release-news](https://mp.weixin.qq.com/s/hqFHEAPZHcoEfC4ghj3QSA). Good job. ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] Liangda-w commented on a change in pull request #11000: Add Oracle SQL - ASSOCIATE STATISTICS
Posted by GitBox <gi...@apache.org>.
Liangda-w commented on a change in pull request #11000:
URL: https://github.com/apache/shardingsphere/pull/11000#discussion_r658723436
##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/jaxb/cases/domain/segment/impl/index/ExpectedIndex.java
##########
@@ -20,11 +20,17 @@
import lombok.Getter;
import lombok.Setter;
import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.AbstractExpectedIdentifierSQLSegment;
+import org.apache.shardingsphere.test.sql.parser.parameterized.jaxb.cases.domain.segment.impl.table.ExpectedOwner;
Review comment:
Add owner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org