You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/12/07 14:44:20 UTC

[GitHub] [beam] tvalentyn opened a new issue, #24569: [Task]: Support Protobuf v4 in Python SDK.

tvalentyn opened a new issue, #24569:
URL: https://github.com/apache/beam/issues/24569

   ### What needs to happen?
   
   Upgrade upper & lower bounds to use Protobuf v4.
   
   
   ### Issue Priority
   
   Priority: 2
   
   ### Issue Component
   
   Component: dependencies


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn closed issue #24569: [Task]: Support Protobuf v4 in Python SDK.

Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn closed issue #24569: [Task]: Support Protobuf v4 in Python SDK.
URL: https://github.com/apache/beam/issues/24569


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on issue #24569: [Task]: Support Protobuf v4 in Python SDK.

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on issue #24569:
URL: https://github.com/apache/beam/issues/24569#issuecomment-1341315728

   .take-issue


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AnandInguva commented on issue #24569: [Task]: Support Protobuf v4 in Python SDK.

Posted by GitBox <gi...@apache.org>.
AnandInguva commented on issue #24569:
URL: https://github.com/apache/beam/issues/24569#issuecomment-1348639818

   We are still blocked on Tensorflow for the protobuf update. Tensorflow is still on `protobuf >= 3.9.2, < 3.20`
   https://github.com/tensorflow/tensorflow/blob/d5b57ca93e506df258271ea00fc29cf98383a374/tensorflow/tools/pip_package/setup.py#L102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on issue #24569: [Task]: Support Protobuf v4 in Python SDK.

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on issue #24569:
URL: https://github.com/apache/beam/issues/24569#issuecomment-1341077566

   Requirements are specified in: https://github.com/apache/beam/blob/1ba7821a09cb1b9a1793f7044ed64aabf55f7713/sdks/python/setup.py
   
   Protobuf releases switched to v4 in: https://pypi.org/project/protobuf/#history
   
   Let's try to switch to Protobuf v4, or identify (what if anything) doesn't work.
   
   To avoid having a mismatch at startup and at runtime for this dependency, let's tighten the upper bound (e.g. `protobuf<=4.21.11` and rely on dependabot for perodic upgrades, or otherwise make periodic upgrades for every release milestone if we still need special casing (which is the case for MacOS now), how we do with cloudpickle, see: https://github.com/apache/beam/issues/23119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] tvalentyn commented on issue #24569: [Task]: Support Protobuf v4 in Python SDK.

Posted by GitBox <gi...@apache.org>.
tvalentyn commented on issue #24569:
URL: https://github.com/apache/beam/issues/24569#issuecomment-1341079218

   @AnandInguva would you have time sometime this/next week to take a look if Protobuf v4 just works? Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aucampia commented on issue #24569: [Task]: Support Protobuf v4 in Python SDK.

Posted by GitBox <gi...@apache.org>.
aucampia commented on issue #24569:
URL: https://github.com/apache/beam/issues/24569#issuecomment-1378513522

   > We are still blocked on Tensorflow for the protobuf update. Tensorflow is still on `protobuf >= 3.9.2, < 3.20` https://github.com/tensorflow/tensorflow/blob/d5b57ca93e506df258271ea00fc29cf98383a374/tensorflow/tools/pip_package/setup.py#L102
   
   I made an upstream issue to track this:
   
   - https://github.com/tensorflow/tensorflow/issues/59221


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org