You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2016/06/25 13:40:46 UTC

commons-crypto git commit: Use shared constant for class names

Repository: commons-crypto
Updated Branches:
  refs/heads/master 7e3899726 -> 25455430f


Use shared constant for class names

Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/25455430
Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/25455430
Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/25455430

Branch: refs/heads/master
Commit: 25455430f44637fce3cc7b4db6a9a5d4df56e27c
Parents: 7e38997
Author: Sebb <se...@apache.org>
Authored: Sat Jun 25 14:40:43 2016 +0100
Committer: Sebb <se...@apache.org>
Committed: Sat Jun 25 14:40:43 2016 +0100

----------------------------------------------------------------------
 .../org/apache/commons/crypto/cipher/AbstractCipherTest.java     | 4 ++++
 .../java/org/apache/commons/crypto/cipher/JceCipherTest.java     | 2 +-
 .../java/org/apache/commons/crypto/cipher/OpensslCipherTest.java | 2 +-
 3 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/25455430/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
index 07fc53e..aa95db0 100644
--- a/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
+++ b/src/test/java/org/apache/commons/crypto/cipher/AbstractCipherTest.java
@@ -37,6 +37,10 @@ import org.junit.Test;
 
 public abstract class AbstractCipherTest {
 
+    public static final String OPENSSL_CIPHER_CLASSNAME = OpensslCipher.class.getName();
+
+    public static final String JCE_CIPHER_CLASSNAME = JceCipher.class.getName();
+
     // data
     public static final int BYTEBUFFER_SIZE = 1000;
     public String[] cipherTests = null;

http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/25455430/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java
index 6f72b7c..33eca8b 100644
--- a/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java
+++ b/src/test/java/org/apache/commons/crypto/cipher/JceCipherTest.java
@@ -35,7 +35,7 @@ public class JceCipherTest extends AbstractCipherTest {
                 "AES/CBC/NoPadding",
                 "AES/CBC/PKCS5Padding",
                 "AES/CTR/NoPadding"};
-        cipherClass = JceCipher.class.getName();
+        cipherClass = JCE_CIPHER_CLASSNAME;
     }
 
     @BeforeClass

http://git-wip-us.apache.org/repos/asf/commons-crypto/blob/25455430/src/test/java/org/apache/commons/crypto/cipher/OpensslCipherTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/crypto/cipher/OpensslCipherTest.java b/src/test/java/org/apache/commons/crypto/cipher/OpensslCipherTest.java
index 1150d25..9df67f7 100644
--- a/src/test/java/org/apache/commons/crypto/cipher/OpensslCipherTest.java
+++ b/src/test/java/org/apache/commons/crypto/cipher/OpensslCipherTest.java
@@ -37,7 +37,7 @@ public class OpensslCipherTest extends AbstractCipherTest {
                 "AES/CBC/NoPadding",
                 "AES/CBC/PKCS5Padding",
                 "AES/CTR/NoPadding"};
-        cipherClass = OpensslCipher.class.getName();
+        cipherClass = OPENSSL_CIPHER_CLASSNAME;
     }
 
     @Test(expected = NoSuchAlgorithmException.class, timeout = 120000)