You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Hudson <gh...@MIT.EDU> on 2002/08/31 17:30:46 UTC

RE: svn commit: rev 3103 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline

On Fri, 2002-08-30 at 04:34, Sander Striker wrote:
> Why not use strncmp?

Since the last answer fizzled, I'll try: because we have too much
cycle-counting mentality in this project.

Admittedly, strncmp() has the problem that you can get bugs like:

  strncmp(mime_type[0], "text/", 6)

which are hard to see.  (There are disciplines which prevent such bugs,
but they're ugly as hell.)  I've never found it to be a real problem,
though.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: rev 3103 - trunk/subversion/include trunk/subversion/libsvn_wc trunk/subversion/libsvn_subr trunk/subversion/mod_dav_svn trunk/subversion/clients/cmdline

Posted by Greg Stein <gs...@lyra.org>.
On Sat, Aug 31, 2002 at 01:30:46PM -0400, Greg Hudson wrote:
> On Fri, 2002-08-30 at 04:34, Sander Striker wrote:
> > Why not use strncmp?
> 
> Since the last answer fizzled, I'll try: because we have too much
> cycle-counting mentality in this project.

Yah :-)  But I also don't find it to be a problem.

IMO, our performance will mostly be bound by the I/O that we do (thus we
want to minimize the operation count), and by the overall system impact of
the working set size (i.e. we need to reduce our mem footprint).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org