You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/07/11 08:27:04 UTC

[GitHub] [servicecomb-java-chassis] zhufeizzz opened a new issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

zhufeizzz opened a new issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880


   TracingConfiguration没看到有开放扩展地方。我想定制几个地方
   1、Tags，区分CSE和普通的SpringMVC
   2、采样率


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] zhufeizzz edited a comment on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
zhufeizzz edited a comment on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657433510


   @liubao68 我建议是这样：
   1、现在CSE的TracingConfiguration的Bean自动扫描初始化，不支持用户覆盖，希望增加类似@ConditionOnMissingBean注解，支持用户自己覆盖。
   2、升级一下zipkin的版本，现在的brave-5.6版本是18年的，有些特性不支持。
   3、SpanName记录一下URL，便于调用链里面查看
   4、在Tag里面标识一下CSE以区分SpringMVC
   
   可以参考一下Zipkin自带的ControllerSpan样例：
   ![image](https://user-images.githubusercontent.com/4591255/87493374-42146300-c67f-11ea-8d23-90f8b83f387a.png)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] zhufeizzz edited a comment on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
zhufeizzz edited a comment on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657433510


   @liubao68 我建议是这样：
   1、现在CSE的TracingConfiguration的Bean自动扫描初始化，不支持用户覆盖，希望增加类似@ConditionOnMissingBean注解，支持用户自己覆盖。
   2、升级一下zipkin的版本，现在的brave-5.6版本是18年的，有些特性不支持。
   3、SpanName记录一下URL，便于调用链里面查看
   4、在Tag里面标识一下CSE以区分SpringMVC
   
   可以参考一下Zipkin自带的ControllerSpan样例：
   ![image](https://user-images.githubusercontent.com/4591255/87493415-59535080-c67f-11ea-961d-854eec084ac4.png)
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
liubao68 commented on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657420605


   这个功能不是特别熟悉，这里有两个文档，可以参考下：
   https://docs.servicecomb.io/java-chassis/zh_CN/general-development/customized-tracing/
   https://docs.servicecomb.io/java-chassis/zh_CN/general-development/customized-tracing/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] zhufeizzz commented on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
zhufeizzz commented on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657433510


   > 这个功能不是特别熟悉，这里有两个文档，可以参考下：
   @liubao68 我建议是这样
   1、现在CSE的TracingConfiguration的Bean自动扫描初始化，不支持用户覆盖，希望增加类似@ConditionOnMissingBean注解，支持用户自己覆盖。
   2、建议升级一下zipkin的版本，现在的5.6版本是18年的，有些特性不支持。
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] zhufeizzz edited a comment on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
zhufeizzz edited a comment on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657433510


   
   @liubao68 我建议是这样
   1、现在CSE的TracingConfiguration的Bean自动扫描初始化，不支持用户覆盖，希望增加类似@ConditionOnMissingBean注解，支持用户自己覆盖。
   2、建议升级一下zipkin的版本，现在的brave-5.6版本是18年的，有些特性不支持。
   3、SpanName记录一下URL，便于查看
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] xingx2 commented on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
xingx2 commented on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-1043836908


   调用RpcSchema定义的api时追踪信息不全，http.path只显示方法名，不显示SchemaId或实际的path（/类名/方法名）。
   有什么方法可以获得实际path或者schemaId吗？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] zhufeizzz edited a comment on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
zhufeizzz edited a comment on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657433510


   @liubao68 我建议是这样：
   1、现在CSE的TracingConfiguration的Bean自动扫描初始化，不支持用户覆盖，希望增加类似@ConditionOnMissingBean注解，支持用户自己覆盖。
   2、升级一下zipkin的版本，现在的brave-5.6版本是18年的，有些特性不支持。
   3、SpanName记录一下URL，便于调用链里面查看
   4、在Tag里面标识一下CSE以区分SpringMVC
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] xingx2 edited a comment on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
xingx2 edited a comment on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-1043836908


   发现调用RpcSchema定义的api时追踪信息不全，http.path只显示方法名，不显示SchemaId或实际的path（/类名/方法名）。
   有什么方法可以获得实际path或者schemaId吗？


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 edited a comment on issue #1880: Zipkin的Tracing不能自己定制吗？比如采样率

Posted by GitBox <gi...@apache.org>.
liubao68 edited a comment on issue #1880:
URL: https://github.com/apache/servicecomb-java-chassis/issues/1880#issuecomment-657420605


   这个功能不是特别熟悉，这里有两个文档，可以参考下：
   https://docs.servicecomb.io/java-chassis/zh_CN/general-development/microservice-invocation-chain/
   https://docs.servicecomb.io/java-chassis/zh_CN/general-development/customized-tracing/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org