You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Daniel Gredler (JIRA)" <ji...@apache.org> on 2010/02/23 01:19:27 UTC
[jira] Created: (HTTPCLIENT-916) RFE: Make Credentials Serializable
RFE: Make Credentials Serializable
----------------------------------
Key: HTTPCLIENT-916
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
Project: HttpComponents HttpClient
Issue Type: Improvement
Components: HttpClient
Affects Versions: 4.0.1
Reporter: Daniel Gredler
Priority: Minor
I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-916) RFE: Make Credentials Serializable
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-916:
-----------------------------------------
Attachment: HTTPCLIENT-916-tests.patch
As far as I know a class does not have to comply with the Java Bean spec in order to be Serializable. Both HttpHost and HttpVersion are valid Serializable while they do not have a no arg constructor and have final fields.
I always wanted to keep persistence aspects out of HttpClient but, if there is popular demand for it, I can live with making BasicUserPrincipal, NTUserPrincipal, as well as BasicClientCookie, BasicClientCookie2, and BasicCookieStore Serializable.
Oleg
> RFE: Make Credentials Serializable
> ----------------------------------
>
> Key: HTTPCLIENT-916
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth, HttpClient, HttpCookie
> Affects Versions: 4.0.1
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 4.1 Alpha2
>
> Attachments: HTTPCLIENT-916-tests.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
> The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-916) RFE: Make Credentials
Serializable
Posted by "Johannes Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837140#action_12837140 ]
Johannes Koch commented on HTTPCLIENT-916:
------------------------------------------
AFAIK, classes implementing Serializable must have a non-argument constructor and non-final member variables. This would have to be changed. However, I support this request. Or add a way to create serializable versions of Credentials (and Headers?).
> RFE: Make Credentials Serializable
> ----------------------------------
>
> Key: HTTPCLIENT-916
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpClient
> Affects Versions: 4.0.1
> Reporter: Daniel Gredler
> Priority: Minor
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
> The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-916) RFE: Make Credentials
Serializable
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838863#action_12838863 ]
Oleg Kalnichevski commented on HTTPCLIENT-916:
----------------------------------------------
I very much regret making HttpHost and HttpVersion serializable. In my opinion persistence aspects should be kept out of HttpCore. Why do you want those classes serializable?
Oleg
> RFE: Make Credentials Serializable
> ----------------------------------
>
> Key: HTTPCLIENT-916
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth, HttpClient, HttpCookie
> Affects Versions: 4.0.1
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 4.1 Alpha2
>
> Attachments: HTTPCLIENT-916-tests.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
> The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Resolved: (HTTPCLIENT-916) RFE: Make Credentials
Serializable
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski resolved HTTPCLIENT-916.
------------------------------------------
Resolution: Fixed
Fixed in SVN trunk
Oleg
> RFE: Make Credentials Serializable
> ----------------------------------
>
> Key: HTTPCLIENT-916
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth, HttpClient, HttpCookie
> Affects Versions: 4.0.1
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 4.1 Alpha2
>
> Attachments: HTTPCLIENT-916-tests.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
> The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Updated: (HTTPCLIENT-916) RFE: Make Credentials Serializable
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Oleg Kalnichevski updated HTTPCLIENT-916:
-----------------------------------------
Component/s: HttpCookie
HttpAuth
Fix Version/s: 4.1 Alpha2
> RFE: Make Credentials Serializable
> ----------------------------------
>
> Key: HTTPCLIENT-916
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth, HttpClient, HttpCookie
> Affects Versions: 4.0.1
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 4.1 Alpha2
>
> Attachments: HTTPCLIENT-916-tests.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
> The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org
[jira] Commented: (HTTPCLIENT-916) RFE: Make Credentials
Serializable
Posted by "Johannes Koch (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838859#action_12838859 ]
Johannes Koch commented on HTTPCLIENT-916:
------------------------------------------
Do you mind making BasicHeader and BufferedHeader also implement Serializable?
> RFE: Make Credentials Serializable
> ----------------------------------
>
> Key: HTTPCLIENT-916
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-916
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Components: HttpAuth, HttpClient, HttpCookie
> Affects Versions: 4.0.1
> Reporter: Daniel Gredler
> Priority: Minor
> Fix For: 4.1 Alpha2
>
> Attachments: HTTPCLIENT-916-tests.patch
>
> Original Estimate: 0.25h
> Remaining Estimate: 0.25h
>
> I've been working on upgrading the HtmlUnit library to use HttpClient 4, and I've realized that we could eliminate some hackish internal code if Credentials instances were Serializable. I don't really see a downside, and this would be a huge convenience for us.
> The change would involve making the org.apache.http.auth.Credentials interface extend Serializable, and having org.apache.http.auth.BasicUserPrincipal and org.apache.http.auth.NTUserPrincipal implement Serializable (plus serialVersionUIDs where appropriate, I guess).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org