You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/15 09:10:13 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#5197: Extract Inventory data prepare to ShardingScalingPreparer
KomachiSion opened a new pull request #5197: Extract Inventory data prepare to ShardingScalingPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5197
For #5106 .
Changes proposed in this pull request:
- Extract Inventory data prepare to ShardingScalingPreparer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5197:
Extract Inventory data prepare to ShardingScalingPreparer
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5197: Extract Inventory data prepare to ShardingScalingPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5197#issuecomment-613959412
## Pull Request Test Coverage Report for [Build 11071](https://coveralls.io/builds/30088645)
* **65** of **77** **(84.42%)** changed or added relevant lines in **7** files are covered.
* **4** unchanged lines in **3** files lost coverage.
* Overall coverage decreased (**-0.03%**) to **57.491%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/preparer/splitter/InventoryDataTaskSplitter.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fpreparer%2Fsplitter%2FInventoryDataTaskSplitter.java#L134) | 61 | 62 | 98.39%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/DefaultSyncTaskFactory.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2FDefaultSyncTaskFactory.java#L35) | 0 | 1 | 0.0%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/ScalingJobController.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2FScalingJobController.java#L54) | 0 | 2 | 0.0%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskController.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskController.java#L47) | 0 | 2 | 0.0%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/preparer/ShardingScalingJobPreparer.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fpreparer%2FShardingScalingJobPreparer.java#L38) | 0 | 6 | 0.0%
<!-- | **Total:** | **65** | **77** | **84.42%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/inventory/InventoryDataSyncTaskGroup.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Finventory%2FInventoryDataSyncTaskGroup.java#L57) | 1 | 51.28% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/inventory/InventoryDataSyncTask.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2Finventory%2FInventoryDataSyncTask.java#L83) | 1 | 75.47% |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/synctask/DefaultSyncTaskFactory.java](https://coveralls.io/builds/30088645/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fsynctask%2FDefaultSyncTaskFactory.java#L31) | 2 | 0% |
<!-- | **Total:** | **4** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/30088645/badge)](https://coveralls.io/builds/30088645) |
| :-- | --: |
| Change from base [Build 11069](https://coveralls.io/builds/30087124): | -0.03% |
| Covered Lines: | 11835 |
| Relevant Lines: | 20586 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5197:
Extract Inventory data prepare to ShardingScalingPreparer
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5197: Extract Inventory data prepare to ShardingScalingPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5197:
Extract Inventory data prepare to ShardingScalingPreparer
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5197: Extract Inventory data prepare to ShardingScalingPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5197#issuecomment-613957188
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=h1) Report
> Merging [#5197](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/50b35685b8073f9e99a0652e72e87b5149643dbb&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `80.51%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5197 +/- ##
=========================================
Coverage 54.06% 54.06%
- Complexity 404 406 +2
=========================================
Files 1157 1159 +2
Lines 20590 20586 -4
Branches 3710 3706 -4
=========================================
- Hits 11131 11130 -1
+ Misses 8765 8764 -1
+ Partials 694 692 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...phere/shardingscaling/core/ShardingScalingJob.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL1NoYXJkaW5nU2NhbGluZ0pvYi5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gscaling/core/controller/ScalingJobController.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvU2NhbGluZ0pvYkNvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...aling/core/controller/task/SyncTaskController.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL2NvbnRyb2xsZXIvdGFzay9TeW5jVGFza0NvbnRyb2xsZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ling/core/preparer/ShardingScalingJobPreparer.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3ByZXBhcmVyL1NoYXJkaW5nU2NhbGluZ0pvYlByZXBhcmVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...gscaling/core/synctask/DefaultSyncTaskFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL0RlZmF1bHRTeW5jVGFza0ZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | `0.00 <0.00> (-1.00)` | |
| [...e/preparer/splitter/InventoryDataTaskSplitter.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3ByZXBhcmVyL3NwbGl0dGVyL0ludmVudG9yeURhdGFUYXNrU3BsaXR0ZXIuamF2YQ==) | `93.54% <93.54%> (ø)` | `1.00 <1.00> (?)` | |
| [...core/synctask/inventory/InventoryDataSyncTask.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL2ludmVudG9yeS9JbnZlbnRvcnlEYXRhU3luY1Rhc2suamF2YQ==) | `71.69% <100.00%> (-0.86%)` | `0.00 <0.00> (ø)` | |
| [...synctask/inventory/InventoryDataSyncTaskGroup.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL2ludmVudG9yeS9JbnZlbnRvcnlEYXRhU3luY1Rhc2tHcm91cC5qYXZh) | `46.15% <100.00%> (-30.55%)` | `0.00 <0.00> (ø)` | |
| [.../communication/jdbc/execute/JDBCExecuteEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmdwcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRlL0pEQkNFeGVjdXRlRW5naW5lLmphdmE=) | `22.22% <0.00%> (-9.36%)` | `0.00% <0.00%> (ø%)` | |
| ... and [15 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=footer). Last update [50b3568...7c1d4c4](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5197?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services