You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Bilgin Ibryam (JIRA)" <ji...@apache.org> on 2007/09/06 10:04:31 UTC
[jira] Created: (OFBIZ-1227) survey screen fix
survey screen fix
-----------------
Key: OFBIZ-1227
URL: https://issues.apache.org/jira/browse/OFBIZ-1227
Project: OFBiz
Issue Type: Bug
Components: content
Affects Versions: SVN trunk
Reporter: Bilgin Ibryam
Priority: Minor
Fix For: SVN trunk
Here i will explain the bugs fixed:
if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528417 ]
Bilgin Ibryam commented on OFBIZ-1227:
--------------------------------------
>Yes, already answered survey. Problem is, I can't order the item again! That's the bug.
Are you sure about it ? Which product ? There are only two surveys from demo data with allowMultiple='N' and they are not from type "CART_ADD" , which means they are not supposed to appears while adding to cart .
>I think some surveys can be taken without having to be logged. isAnonymous "Y". Test those?
This is possible in ecommerce application. I will change it in order manager, where in general you are always logged in. There is meaning to let it auth="false"
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529078 ]
Bilgin Ibryam commented on OFBIZ-1227:
--------------------------------------
Jonathon,
>I was testing "Mouse Hand Poll" with GZ-2644 . Shouldn't the allowMultiple "N" mean that the survey is only asked once, and that the product can be bought again? Or should >allowMultiple "N" not be used with "Add-To Cart" survey trigger? I tried triggers "Check-Out" and "Sales Order Placement", but those don't seem to work.
I really donot get what's the bug you mentioned.
"Mouse Hand Poll" is with allowMultiple "N" , which means that you can answer to this survey only once. But this survey is not connected to GZ-2644 or some other products, so this survey is not stopping you from adding this product again and again.
But if you did some changes to demo data and connected the prodcut to Mouse Hand Poll, then it could stop you from adding the productt again, i do not know.
In any case, i still cannot see here a bug...
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1227) survey screen fix
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1227:
---------------------------------
Attachment: survey.patch
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528344 ]
Bilgin Ibryam commented on OFBIZ-1227:
--------------------------------------
Jonathon,
Can you tell me please how you got this error "You have already responded to this survey; multiple responses are not allowed" ?
Some surveys (like Mouse Hand Poll and Mini-Poll Poll from demo data ) has allowMultiple='N', so it is allowed only one answer from a partyId.
May be you already answered to this survey and it is not a bug ?
I updated the patch, changing <security https="false" auth="false"/> to <security https="true" auth="true"/> for <request-map uri="additemsurvey">
With this change the bug mentioned in my previous post is fixed.
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529127 ]
Jonathon Wong commented on OFBIZ-1227:
--------------------------------------
> But if you did some changes to demo data and connected the prodcut to Mouse
> Hand Poll
Yes, I connected the product to the poll. Anyway, that bug is not related to this JIRA issue. We'll leave it.
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1227) survey screen fix
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bilgin Ibryam updated OFBIZ-1227:
---------------------------------
Attachment: survey.patch
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527691 ]
Jonathon Wong commented on OFBIZ-1227:
--------------------------------------
Why remove parameter "partyId" for request "ViewSurveyResponses"? Is it because it is not used at all? If so, I agree with it.
> If you search for survey from find survey screen (for example with id = 1)
> you will get all the surveys stating with id=1, but at this stage the survey
> menu will appears, thinking that we choose a survey with id 1
Your fix is correct. The "CommonSurveyDecorator" should not set field "surveyId", nor retrieve entity Survey. Screens like "FindSurvey" depend on "CommonSurveyDecorator", but is not a survey-specific screen. Survey-specific screens are like "EditSurvey", which also depends on "CommonSurveyDecorator".
> if you add a product with survey to shopping cart and try to see the survey,
> the given link is broken
I couldn't reproduce this bug. More details, please?
I searched Ecommerce module, but couldn't find any references to "ViewSurveyResponses".
I also tried using the OrderMgr module to test the surveys. There's a bug in there, surveys cannot be responded to (error msg "You have already responded to this survey; multiple responses are not allowed").
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Bilgin Ibryam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527736 ]
Bilgin Ibryam commented on OFBIZ-1227:
--------------------------------------
Yes, partyId is not used, thats why i removed it.
>> if you add a product with survey to shopping cart and try to see the survey,
>> the given link is broken
>I couldn't reproduce this bug. More details, please?
>From Order manager, Order entry. Then from 'Browse Categories left menu' choose Account Activation category, then Financial Account Activation (FA-001) .
After adding this product to cart, in shopping cart items there is broken link "Surveys:" .
After the order creation, in order view screen, there is again a link (it works but shows all the responses to this survey).
I propose both links to show the EditSurveyResponse screen.
>I searched Ecommerce module, but couldn't find any references to "ViewSurveyResponses".
There is no references to "ViewSurveyResponses". (In ecommerce, profile, surveys, take Survey, after finishing the survey, there is another bug, but i could not fix it and it is not related to this issue. So i didnot report it. )
>I also tried using the OrderMgr module to test the surveys. There's a bug in there, surveys cannot be responded to (error msg "You have >already responded to this survey; >multiple responses are not allowed").
How you test the surveys from OrderMgr, More details, please?
Today while testing on the demo server https://demo.hotwaxmedia.com i found another bug.
If you try to add the same product Financial Account Activation (FA-001) from OrderMgr, after entering the 'Activation Serial Number:' and submitting the form, the request goes here and generates error:
ordermgr/controller.xml:477
<request-map uri="additemsurvey">
<security https="false" auth="false"/>
it should be https="true" auth="true" Is there a reason for not doing so?
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528394 ]
Jonathon Wong commented on OFBIZ-1227:
--------------------------------------
> From Order manager, Order entry. Then from 'Browse Categories left menu'
> ... After adding this product to cart, in shopping cart items there is broken
> link "Surveys:"
I see it. That link is missing the surveyId. So that's why you're deriving the surveyId in ViewSurveyResponses.bsh .
> Can you tell me please how you got this error "You have already responded to
> this survey; multiple responses are not allowed" ? Some surveys (like Mouse
> Hand Poll and Mini-Poll Poll from demo data ) has allowMultiple='N',
Yes, already answered survey. Problem is, I can't order the item again! That's the bug.
> ordermgr/controller.xml:477
> <request-map uri="additemsurvey">
> <security https="false" auth="false"/>
>
> it should be https="true" auth="true" Is there a reason for not doing so?
I think some surveys can be taken without having to be logged. isAnonymous "Y". Test those?
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1227) survey screen fix
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1227.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 4.0
Assignee: Jacques Le Roux
Thanks Bilgin,
Your patch is in trunk revision: 582474 release4.0 582475
Thanks to Jonathon for review and test !
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1227) survey screen fix
Posted by "Jonathon Wong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12528437 ]
Jonathon Wong commented on OFBIZ-1227:
--------------------------------------
>> Yes, already answered survey. Problem is, I can't order the item again! That's the bug.
> Are you sure about it ? Which product ? There are only two surveys from demo
> data with allowMultiple='N' and they are not from type "CART_ADD" , which
> means they are not supposed to appears while adding to cart .
I was testing "Mouse Hand Poll" with GZ-2644 . Shouldn't the allowMultiple "N" mean that the survey is only asked once, and that the product can be bought again? Or should allowMultiple "N" not be used with "Add-To Cart" survey trigger? I tried triggers "Check-Out" and "Sales Order Placement", but those don't seem to work.
>> I think some surveys can be taken without having to be logged. isAnonymous "Y". Test those?
> This is possible in ecommerce application. I will change it in order manager,
> where in general you are always logged in. There is meaning to let it
> auth="false"
Agreed. I'm not sure why it's auth="false" in OrderMgr. Maybe it was cut-and-pasted from Ecommerce controller.xml .
> survey screen fix
> -----------------
>
> Key: OFBIZ-1227
> URL: https://issues.apache.org/jira/browse/OFBIZ-1227
> Project: OFBiz
> Issue Type: Bug
> Components: content
> Affects Versions: SVN trunk
> Reporter: Bilgin Ibryam
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: survey.patch, survey.patch
>
>
> Here i will explain the bugs fixed:
> if you add a product with survey to shopping cart and try to see the survey, the given link is broken. I add some code the get the surveyId from surveyResponseId.
> If you search for survey from find survey screen (for example with id = 1) you will get all the surveys stating with id=1, but at this stage the survey menu will appears, thinking that we choose a survey with id 1. And this survey menu is broken(surveyId=1, it is only a search criteria, not an existing survey id). Removing some unused fields from FindSurveyscreen and CommonSurveyDecorator fixed these bugs.
> I also have a question/proposal: Isn't it better to change the links ( from shopping cart and order review screens ) from ViewSurveyResponses to EditSurveyResponse. If we change it, clicking on the survey link from an order/shoppingcart item, will show us the exact survey response and ability to edit it, instead of all the responses to the survey, as it is now ?
> Bilgin Ibryam
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.