You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Thomas Mueller (JIRA)" <ji...@apache.org> on 2013/05/22 08:23:20 UTC

[jira] [Commented] (OAK-836) MongoMk LogWrapper generics

    [ https://issues.apache.org/jira/browse/OAK-836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13663839#comment-13663839 ] 

Thomas Mueller commented on OAK-836:
------------------------------------

The patch looks good.

Or we just add "dispose" to the MicroKernel API.
                
> MongoMk LogWrapper generics
> ---------------------------
>
>                 Key: OAK-836
>                 URL: https://issues.apache.org/jira/browse/OAK-836
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk
>            Reporter: Alex Parvulescu
>            Priority: Minor
>         Attachments: OAK-836.patch
>
>
> I tried using the LogWrapper and I think that it could be improved by exposing the wrapped mk impl as the actual class not just a _MicroKernel_
> For example this helps with wrapping the _MongoMK_ and making sure the call to #dispose goes where it should (not to the noop from the LogWrapper).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira