svn commit: r831723 - in /commons/proper/dbcp/trunk: findbugs-exclude-filter.xml pom.xml

[ps...@apache.org]

Author: psteitz
Date: Sun Nov  1 18:35:35 2009
New Revision: 831723

URL: http://svn.apache.org/viewvc?rev=831723&view=rev
Log:
Added findbugs exclude filter.

Added:
    commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
Modified:
    commons/proper/dbcp/trunk/pom.xml

Added: commons/proper/dbcp/trunk/findbugs-exclude-filter.xml
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/findbugs-exclude-filter.xml?rev=831723&view=auto
==============================================================================
--- commons/proper/dbcp/trunk/findbugs-exclude-filter.xml (added)
+++ commons/proper/dbcp/trunk/findbugs-exclude-filter.xml Sun Nov  1 18:35:35 2009
@@ -0,0 +1,30 @@
+<?xml version="1.0"?>
+<!--
+   Licensed to the Apache Software Foundation (ASF) under one or more
+   contributor license agreements.  See the NOTICE file distributed with
+   this work for additional information regarding copyright ownership.
+   The ASF licenses this file to You under the Apache License, Version 2.0
+   (the "License"); you may not use this file except in compliance with
+   the License.  You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.
+-->
+
+<!--
+  This file contains some false positive bugs detected by findbugs. Their
+  false positive nature has been analyzed individually and they have been
+  put here to instruct findbugs it must ignore them.
+-->
+<FindBugsFilter>
+  <!--  Minimum JDK level is still 1.4, so valueOf(int) is not available -->
+  <Match>
+    <Class name="org.apache.commons.dbcp.PoolingConnection$PStmtKey" />
+    <Bug pattern="DM_NUMBER_CTOR" />
+  </Match>
+</FindBugsFilter>

Modified: commons/proper/dbcp/trunk/pom.xml
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/trunk/pom.xml?rev=831723&r1=831722&r2=831723&view=diff
==============================================================================
--- commons/proper/dbcp/trunk/pom.xml (original)
+++ commons/proper/dbcp/trunk/pom.xml Sun Nov  1 18:35:35 2009
@@ -310,6 +310,7 @@
           <configuration>
             <threshold>Normal</threshold>
             <effort>Default</effort>
+            <excludeFilterFile>${basedir}/findbugs-exclude-filter.xml</excludeFilterFile>
           </configuration>
         </plugin>
         <plugin>