You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2022/07/21 19:20:35 UTC
[kudu-CR] [script] Add encryption flag to start kudu script
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18769
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
[script] Add encryption flag to start_kudu script
Change-Id: I374f0653d2259ef028979f247c922e8981808498
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/18769/1
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] [script] Add encryption flag to start kudu script
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18769 )
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jul 2022 22:16:48 +0000
Gerrit-HasComments: No
[kudu-CR] [script] Add encryption flag to start kudu script
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/18769 )
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18769/2/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:
http://gerrit.cloudera.org:8080/#/c/18769/2/src/kudu/scripts/start_kudu.sh@271
PS2, Line 271: echo " PID $!"
is this necessary or was just a debug line?
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jul 2022 19:32:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [script] Add encryption flag to start kudu script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18769 )
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18769/2/src/kudu/scripts/start_kudu.sh
File src/kudu/scripts/start_kudu.sh:
http://gerrit.cloudera.org:8080/#/c/18769/2/src/kudu/scripts/start_kudu.sh@271
PS2, Line 271: echo " PID $!"
> is this necessary or was just a debug line?
I find it helpful, sometimes I need to attach a gdb to a server.
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Jul 2022 19:34:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [script] Add encryption flag to start kudu script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18769 )
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
[script] Add encryption flag to start_kudu script
Change-Id: I374f0653d2259ef028979f247c922e8981808498
Reviewed-on: http://gerrit.cloudera.org:8080/18769
Reviewed-by: Zoltan Chovan <zc...@cloudera.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
Tested-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/scripts/start_kudu.sh
1 file changed, 16 insertions(+), 1 deletion(-)
Approvals:
Zoltan Chovan: Looks good to me, but someone else must approve
Alexey Serbin: Looks good to me, approved
Attila Bukor: Verified
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR] [script] Add encryption flag to start kudu script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18769 )
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jul 2022 08:40:43 +0000
Gerrit-HasComments: No
[kudu-CR] [script] Add encryption flag to start kudu script
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [script] Add encryption flag to start_kudu script
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/18769
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I374f0653d2259ef028979f247c922e8981808498
Gerrit-Change-Number: 18769
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>